Skip to content

feat(dynamic-streams): Avoid parsing strings in ConfigComponentResolver #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2025
Merged

feat(dynamic-streams): Avoid parsing strings in ConfigComponentResolver #769

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
679b3ca
Avoid parsing strings in ConfigComponentResolver
tolik0 Sep 22, 2025
9472e09
Add unit test
tolik0 Sep 23, 2025
96d55c5
Auto-fix lint and format issues
Sep 23, 2025
11d4931
Merge branch 'main' into tolik0/dynamic-streams/avoid-parsing-strings…
tolik0 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airbyte_cdk/sources/declarative/resolvers/config_components_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,11 @@ def resolve_components(
)

path = [path.eval(self.config, **kwargs) for path in resolved_component.field_path]
parsed_value = self._parse_yaml_if_possible(value)
# Avoid parsing strings that are meant to be strings
if not (isinstance(value, str) and valid_types == (str,)):
parsed_value = self._parse_yaml_if_possible(value)
else:
parsed_value = value
updated = dpath.set(updated_config, path, parsed_value)

if parsed_value and not updated and resolved_component.create_or_update:
Expand Down
Loading