🚨 Source Outreach: Change dict type relationship responses to be integers instead of arrays of length 1#60843
🚨 Source Outreach: Change dict type relationship responses to be integers instead of arrays of length 1#60843kyleromines wants to merge 15 commits intoairbytehq:masterfrom
Conversation
|
kyleromines is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
👋 Welcome to Airbyte!Thank you for your contribution from kyleromines/airbyte! We're excited to have you in the Airbyte community. Helpful Resources
PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
If you have any questions, feel free to ask in the PR comments or join our Slack community. |
|
Marcos Marx (@marcosmarxm) Was the CI pipeline changed? I see the connector tests is trying to look for a secrets file |
Marcos Marx (marcosmarxm)
left a comment
There was a problem hiding this comment.
kyleromines this will cause a breaking change, data type from list to integer. Users will need to refresh their data and full load.
|
Marcos Marx (@marcosmarxm) I agree, but the current output is not correct. Do you have ways to handle this? I know in the open source version I can choose the connector version. I also see a breaking changes section in the metadata.yaml but not sure how to set that. |
|
Not a problem kyleromines I'll make the necessary changes as your changes looks important to make the connector more usable. |
|
Marcos Marx (@marcosmarxm) Thanks for the update! |
|
Marcos Marx (@marcosmarxm) Any update on this one? Thanks. |
|
/run-connector-tests
|
|
/format-fix
|
|
Marcos Marx (@marcosmarxm) Anything I can do to help with this one? |
|
/run-connector-tests
|
|
Charles (@cgardens) CI tests fail on looking for a secrets config. How can this be solved if secrets are git ignored? |
|
If you look at this job, I think there's actually a failure. When I run it, it uses airbyte's credts but there is this real failure. https://github.com/airbytehq/airbyte/actions/runs/16610286086/job/46991856522 . Do you think you can take a look at it? If we can get it resolved, we'll get this merged! |
|
Charles (@cgardens) The only error I see there is "Bad Request for url: https://api.outreach.io/oauth/token'" that only happens when it gets bad credentials. I can the the integration tests successfully with my outreach credentials. Or is there an error I am missing in that log? |
|
/run-connector-tests
|
|
kyleromines I'm still seeing some test failures. You can ignore the "breaking change" stuff, but the actual integration test failures need to be addressed. https://github.com/airbytehq/airbyte/actions/runs/16970549116/job/48106153402 |
|
Charles (@cgardens) Can you point me to a line number there that is not "Bad Request for url: https://api.outreach.io/oauth/token'"? |
|
Charles (@cgardens) Whatever credentials are being used to run the integration tests are bad |
|
Charles (@cgardens) I set up BYO creds for this but the action is skipping the post comment step |
|
/run-connector-tests
|
|
Charles (@cgardens) These tests are running against the master branch I think these credentials listed here stored in GSM need to be updated. I recommend plugging the Client ID, Client Secret, and callback URL into an oauth 2.0 authorization tab in a postman request with Then you can click "Get New Access Token" and that will pop up a screen that gives you a new refresh token to update the secret in GSM with. |
|
Charles seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
What
The relationship fields as described in the Outreach API (example) are basically the foreign keys to other objects. Many of these are a 1:1 relationship but the current custom extractor class is putting the singular dicts into an array so the data is being displayed quite weirdly after it gets to the database. Only relationship fields with plural names are array type.
How
Use the
if isinstance(data, dict):line to properly extract the valueReview guide
components.pymanifest.yamlUser Impact
Can this PR be safely reverted and rolled back?