Skip to content

Comments

🚨 Source Outreach: Change dict type relationship responses to be integers instead of arrays of length 1#60843

Open
kyleromines wants to merge 15 commits intoairbytehq:masterfrom
kyleromines:source-outreach-fix-array
Open

🚨 Source Outreach: Change dict type relationship responses to be integers instead of arrays of length 1#60843
kyleromines wants to merge 15 commits intoairbytehq:masterfrom
kyleromines:source-outreach-fix-array

Conversation

@kyleromines
Copy link
Contributor

@kyleromines kyleromines commented May 21, 2025

What

The relationship fields as described in the Outreach API (example) are basically the foreign keys to other objects. Many of these are a 1:1 relationship but the current custom extractor class is putting the singular dicts into an array so the data is being displayed quite weirdly after it gets to the database. Only relationship fields with plural names are array type.

How

Use the if isinstance(data, dict): line to properly extract the value

Review guide

  1. components.py
  2. manifest.yaml

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel
Copy link

vercel bot commented May 21, 2025

kyleromines is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from kyleromines/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.

If you have any questions, feel free to ask in the PR comments or join our Slack community.

@kyleromines
Copy link
Contributor Author

Marcos Marx (@marcosmarxm) Was the CI pipeline changed? I see the connector tests is trying to look for a secrets file

Copy link
Contributor

@marcosmarxm Marcos Marx (marcosmarxm) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kyleromines this will cause a breaking change, data type from list to integer. Users will need to refresh their data and full load.

@kyleromines
Copy link
Contributor Author

Marcos Marx (@marcosmarxm) I agree, but the current output is not correct. Do you have ways to handle this? I know in the open source version I can choose the connector version. I also see a breaking changes section in the metadata.yaml but not sure how to set that.

@marcosmarxm
Copy link
Contributor

Not a problem kyleromines I'll make the necessary changes as your changes looks important to make the connector more usable.

@kyleromines
Copy link
Contributor Author

Marcos Marx (@marcosmarxm) Thanks for the update!

@kyleromines
Copy link
Contributor Author

Marcos Marx (@marcosmarxm) Any update on this one? Thanks.

@marcosmarxm Marcos Marx (marcosmarxm) requested a review from a team as a code owner July 9, 2025 16:22
@marcosmarxm
Copy link
Contributor

Marcos Marx (marcosmarxm) commented Jul 9, 2025

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
✅ Connector CI Tests job completed successfully. See logs for details.

@marcosmarxm
Copy link
Contributor

Marcos Marx (marcosmarxm) commented Jul 9, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (982c494)

@kyleromines
Copy link
Contributor Author

Marcos Marx (@marcosmarxm) Anything I can do to help with this one?

@cgardens
Copy link
Contributor

Charles (cgardens) commented Jul 30, 2025

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
✅ Connector CI Tests job completed successfully. See logs for details.

@kyleromines
Copy link
Contributor Author

Charles (@cgardens) CI tests fail on looking for a secrets config. How can this be solved if secrets are git ignored?

@cgardens
Copy link
Contributor

If you look at this job, I think there's actually a failure. When I run it, it uses airbyte's credts but there is this real failure. https://github.com/airbytehq/airbyte/actions/runs/16610286086/job/46991856522 . Do you think you can take a look at it? If we can get it resolved, we'll get this merged!

@kyleromines
Copy link
Contributor Author

Charles (@cgardens) The only error I see there is "Bad Request for url: https://api.outreach.io/oauth/token'" that only happens when it gets bad credentials. I can the the integration tests successfully with my outreach credentials. Or is there an error I am missing in that log?

@cgardens
Copy link
Contributor

Charles (cgardens) commented Aug 14, 2025

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
✅ Connector CI Tests job completed successfully. See logs for details.

@github-project-automation github-project-automation bot moved this from Backlog to Ready to Ship in 🧑‍🏭 Community Pull Requests Aug 14, 2025
@cgardens Charles (cgardens) enabled auto-merge (squash) August 14, 2025 16:23
@cgardens
Copy link
Contributor

kyleromines I'm still seeing some test failures. You can ignore the "breaking change" stuff, but the actual integration test failures need to be addressed.

https://github.com/airbytehq/airbyte/actions/runs/16970549116/job/48106153402

@kyleromines
Copy link
Contributor Author

Charles (@cgardens) Can you point me to a line number there that is not "Bad Request for url: https://api.outreach.io/oauth/token'"?

@kyleromines
Copy link
Contributor Author

Charles (@cgardens) Whatever credentials are being used to run the integration tests are bad

@kyleromines
Copy link
Contributor Author

Charles (@cgardens) I set up BYO creds for this but the action is skipping the post comment step

@cgardens
Copy link
Contributor

Charles (cgardens) commented Aug 21, 2025

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
✅ Connector CI Tests job completed successfully. See logs for details.

@kyleromines
Copy link
Contributor Author

Charles (@cgardens) These tests are running against the master branch

I think these credentials listed here stored in GSM need to be updated.

I recommend plugging the Client ID, Client Secret, and callback URL into an oauth 2.0 authorization tab in a postman request with
Auth URL: https://api.outreach.io/oauth/authorize
Access Token URL: https://api.outreach.io/oauth/token
Scope: prospects.read sequences.read sequenceStates.read sequenceSteps.read calls.read mailings.read accounts.read opportunities.read personas.read mailboxes.read stages.read users.read tasks.read templates.read snippets.read callDispositions.read callPurposes.read

Then you can click "Get New Access Token" and that will pop up a screen that gives you a new refresh token to update the secret in GSM with.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kyleromines
✅ marcosmarxm
❌ Charles


Charles seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready to Ship

Development

Successfully merging this pull request may close these issues.

5 participants