-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix(source-snapchat-marketing): "Start time should start at the beginning of an hour" error #63276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ali-taha-ahmed is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
👋 Welcome to Airbyte!Thank you for your contribution from ali-taha-ahmed/airbyte! We're excited to have you in the Airbyte community. Helpful Resources
PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
If you have any questions, feel free to ask in the PR comments or join our Slack community. Tips for Working with CI
|
/format-fix |
/bump-version changelog="Fix Start time should start at the beginning of an hour error" |
@tolik0 @darynaishchenko can you check this contribution as you made a fix to datetime in current version? |
note to self: referred to internal team -- extensibility |
airbyte-integrations/connectors/source-snapchat-marketing/manifest.yaml
Outdated
Show resolved
Hide resolved
/bump-version changelog="Fix start time for stats streams"
|
…ix-Start-time-to-beginning-of-the-hour
/format-fix
|
/run-cat-tests
|
Tests are in this PR: #64551 |
…ix-Start-time-to-beginning-of-the-hour
Anatolii validated this on his branch! |
What
Fixes the timestamp formatting for start_datetime and end_datetime to ensure compatibility with Snapchat's API, which requires times to start exactly at the beginning of the hour.
Resolves: #61499
How
For daily streams, set datetime format to:
%Y-%m-%dT%H:00:00
to ensure times always start at the top of the hour.
For hourly streams, set datetime format to:
%Y-%m-%dT%H:00:00.000000%z
to match Snapchat’s expected precision and timezone formatting.
These formats fix invalid start/end time errors from the API and align partitioning with Airbyte’s incremental sync logic.
Review guide
User Impact
✔ No more 400 errors due to improperly formatted timestamps
Can this PR be safely reverted and rolled back?