Skip to content

Conversation

ali-taha-ahmed
Copy link
Contributor

What

Fixes the timestamp formatting for start_datetime and end_datetime to ensure compatibility with Snapchat's API, which requires times to start exactly at the beginning of the hour.
Resolves: #61499

How

For daily streams, set datetime format to:

%Y-%m-%dT%H:00:00
to ensure times always start at the top of the hour.

For hourly streams, set datetime format to:

%Y-%m-%dT%H:00:00.000000%z
to match Snapchat’s expected precision and timezone formatting.
These formats fix invalid start/end time errors from the API and align partitioning with Airbyte’s incremental sync logic.

Review guide

User Impact

✔ No more 400 errors due to improperly formatted timestamps

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jul 14, 2025

@ali-taha-ahmed is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from ali-taha-ahmed/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

  1. "Vercel" CI failures. You can always ignore these. These are our docs builds but they can only be run by approval. A maintainer will approve the workflow upon request, but this failure should not be of concern.
  2. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  3. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  4. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

@ali-taha-ahmed
Copy link
Contributor Author

/format-fix

@ali-taha-ahmed
Copy link
Contributor Author

/bump-version changelog="Fix Start time should start at the beginning of an hour error"

@marcosmarxm
Copy link
Contributor

@tolik0 @darynaishchenko can you check this contribution as you made a fix to datetime in current version?

@cgardens
Copy link
Contributor

cgardens commented Aug 4, 2025

note to self: referred to internal team -- extensibility

@tolik0
Copy link
Contributor

tolik0 commented Aug 5, 2025

/bump-version changelog="Fix start time for stats streams"

Bump Version job started... Check job output.

✅ Changes applied successfully. (3feec79)

@tolik0
Copy link
Contributor

tolik0 commented Aug 7, 2025

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@tolik0
Copy link
Contributor

tolik0 commented Aug 7, 2025

/run-cat-tests

Connector CAT tests started... Check job output.

If the connector supports live tests or regression tests, you may want to run those now also:

CAT Tests completed.
Important: Please check the job output to verify the results.

@tolik0
Copy link
Contributor

tolik0 commented Aug 7, 2025

Tests are in this PR: #64551

@github-project-automation github-project-automation bot moved this from Backlog to Ready to Ship in 🧑‍🏭 Community Pull Requests Aug 11, 2025
@katmarkham katmarkham merged commit 5b99754 into airbytehq:master Aug 12, 2025
38 of 39 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Ship to Done in 🧑‍🏭 Community Pull Requests Aug 12, 2025
@katmarkham
Copy link
Contributor

Anatolii validated this on his branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

[source-snapchat-marketing] "Start time should start at the beginning of an hour."

7 participants