-
Notifications
You must be signed in to change notification settings - Fork 4.8k
🐛 Source CIN7: fix product_availability primary key for multi-location … #64118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source CIN7: fix product_availability primary key for multi-location … #64118
Conversation
…support - Change primary key from [ID] to [ID, Location] - Fixes bug where same product in multiple locations caused data loss - Location is required field per CIN7 API docs - Enables proper deduplication for multi-location inventory
@alexbirch-xy is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
👋 Welcome to Airbyte!Thank you for your contribution from alex-birch/airbyte! We're excited to have you in the Airbyte community. Helpful Resources
PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
If you have any questions, feel free to ask in the PR comments or join our Slack community. Tips for Working with CI
|
- Increment version from 0.3.10 to 0.3.11 for primary key fix - Enable acceptance tests as required for medium/high use connectors
- Added test secrets configuration for acceptance tests in metadata.yaml - Updated changelog in cin7.md to reflect version 0.3.11 release and acceptance tests enablement
…hangelog formatting - Added 'connectorSubtype: api' to metadata.yaml - Corrected link formatting in changelog for version 0.3.11 in cin7.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Please fix the merge conflicts and then we can get this merged.
Thanks! Conflicts resolved and latest master merged, ready for review. |
changelog fix
dockerimagetag bump
Hi there - I've updated the branch again to be inline with the latest master. @cgardens Is there anything else I need to do to get this merged? |
Hi there - I've updated the branch again to resolve the conflicts. @cgardens Is there anything else I need to do to get this merged? I'd really like to get it in so I can start using Airbyte's connector. |
/run-connector-tests
|
/run-connector-tests
|
Thank you for your contribution! |
What
Fixes the primary key configuration for the
product_availability
stream in the CIN7 connector to support multi-location inventory tracking.Problem
The current primary key configuration uses only
[ID]
(product ID), which prevents the same product from being tracked across multiple locations. This causes data loss during deduplication when a product exists in multiple warehouses/locations.Solution
Changed primary key from
[ID]
to[ID, Location]
to create a composite key that uniquely identifies each product-location combination.Why
Location
field is required per CIN7 API documentationTesting
https://help.core.cin7.com/hc/en-us/articles/9034523140879-ProductAvailability

Files Changed
airbyte-integrations/connectors/source-cin7/manifest.yaml