Update AirbyteTypeToMssqlType.kt

[cad2040]

Summary of Changes

1. Added two new enum values to MssqlType:
   • NVARCHAR(Types.NVARCHAR, sqlStringOverride = "NVARCHAR(MAX)")
   • NVARCHAR_INDEX(Types.NVARCHAR, sqlStringOverride = "NVARCHAR(200)")
2. Updated the conversion logic to use NVARCHAR instead of VARCHAR for string types
3. Maintained backward compatibility by keeping the existing VARCHAR types

What

Allowing the connector to correctly handle Unicode characters, address issue 64496

How

By updating conversion logic of strings to use nvarchar instead of varchar

Review guide

1. airbyte-integrations/connectors/destination-mssql/src/main/kotlin/io/airbyte/integrations/destination/mssql/v2/convert/AirbyteTypeToMssqlType.kt

User Impact

Positive Impact:

• Fixes character encoding corruption - Special characters like parentheses (, ), em dashes —, and smart quotes " will no longer be corrupted during MSSQL bulk insert operations
• Improves data integrity - Unicode characters will be properly preserved and displayed correctly in destination MSSQL tables
  Eliminates data quality issues - Text fields will maintain their original meaning and readability
• Better internationalization support - Non-English characters and special symbols will work correctly
  No Negative Side Effects:
• Backward compatible - Existing VARCHAR columns remain unchanged
• Performance neutral - NVARCHAR has minimal performance impact compared to VARCHAR
• No breaking changes - Existing syncs will continue to work
• Standards compliant - Uses proper Unicode data types as recommended by Microsoft

Can this PR be safely reverted and rolled back?

• YES 💚

[CLAassistant]

All committers have signed the CLA.

[github-actions]

👋 Welcome to Airbyte!

Thank you for your contribution from cad2040/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

• PR Guidelines: Check our guidelines for contributions.
• Developing Connectors Locally: Learn how to set up your environment and develop connectors locally.
• If you enable BYO Connector Credentials within your fork, you can view your test results here:
  

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

• /format-fix - Fixes most formatting issues.
• /bump-version - Bumps connector versions.
• /run-connector-tests - Runs connector tests.
• /run-cat-tests - Runs CAT tests.
• /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
   • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

📝 Edit this welcome message.

[cad2040]

The "Format Check" failure is due to a broken GitHub Action dependency (abinoda/slack-action repository not found), not because of my code changes. The actual formatting check never ran due to this setup failure.

The Airbyte team needs to update their workflow to use a working Slack action or remove the Slack notification step.

My code changes are ready for review once the workflow issue is resolved.

This fix addresses issue 64496

[davinchia]

@cad2040 it looks like the build has proper failures. Please take a look!

[cad2040]

@cad2040 it looks like the build has proper failures. Please take a look!

Thanks I have updated the failing unit tests to now expect NVARCHAR and not VARCHAR.

[cad2040]

Okay, it is now failing due to a missing credential in a secret file, which I think is related to the build pipelines

[cgardens]

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
✅ Connector CI Tests job completed successfully. See logs for details.