-
Notifications
You must be signed in to change notification settings - Fork 4.8k
🐛 destination-snowflake: Fix to enable syncing a row_number column from the source to Snowflake #66591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
🐛 destination-snowflake: Fix to enable syncing a row_number column from the source to Snowflake #66591
Conversation
Aliasing a column as row_number prevents a similarly named column in the source from syncing to Snowflake. ROW_NUMBER is already registered as a Snowflake keyword. It should not be used as a column alias
👋 Welcome to Airbyte!Thank you for your contribution from aapatankar/airbyte! We're excited to have you in the Airbyte community. Helpful Resources
PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
If you have any questions, feel free to ask in the PR comments or join our Slack community. Tips for Working with CI
|
Updated the subject of version 3.15.11 to clarify the fix related to syncing a row_number column.
@aapatankar hi, could you please resolve conflicts? After this we will review your PR. |
…_cant_sync_to_snowflake_destination
…nowflake_destination
@DanyloGL - Conflicts are resolved |
Aliasing a column as row_number prevents a similarly named column in the source from syncing to Snowflake. ROW_NUMBER is already registered as a Snowflake keyword. It should not be used as a column alias
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?