-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat(source-workday) update docs #67214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
π Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
markdownlint
[markdownlint] reported by reviewdog πΆ
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
* Report IDs - Each report in Workday has a unique Report ID. |
/format-fix
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
docs/integrations/enterprise-connectors/source-workday-migrations.md
Outdated
Show resolved
Hide resolved
docs/integrations/enterprise-connectors/source-workday-migrations.md
Outdated
Show resolved
Hide resolved
docs/integrations/enterprise-connectors/source-workday-migrations.md
Outdated
Show resolved
Hide resolved
docs/integrations/enterprise-connectors/source-workday-migrations.md
Outdated
Show resolved
Hide resolved
docs/integrations/enterprise-connectors/source-workday-migrations.md
Outdated
Show resolved
Hide resolved
Approved review not to be blocking but please make docs changes as noted above! Thanks :) |
Deploy preview for airbyte-docs ready! β
Preview Built with commit 418bb0f. |
@@ -0,0 +1,18 @@ | |||
# Workday Migration Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Headings] 'Workday Migration Guide' should use sentence-style capitalization.
## Upgrading to 1.0.0 | ||
|
||
This release splits Source Workday into two separate connectors - Source Workday (for RaaS streams) and Source Workday REST (for REST streams). | ||
The connector you're currently using is deprecating REST streams and will continue to support only RAAS streams. REST streams will be available in the new Source Workday REST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
## Upgrading to 1.0.0 | ||
|
||
This release splits Source Workday into two separate connectors - Source Workday (for RaaS streams) and Source Workday REST (for REST streams). | ||
The connector you're currently using is deprecating REST streams and will continue to support only RAAS streams. REST streams will be available in the new Source Workday REST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π« [vale] reported by reviewdog πΆ
[Google.Spacing] 's. R' should have one space.
## Upgrading to 1.0.0 | ||
|
||
This release splits Source Workday into two separate connectors - Source Workday (for RaaS streams) and Source Workday REST (for REST streams). | ||
The connector you're currently using is deprecating REST streams and will continue to support only RAAS streams. REST streams will be available in the new Source Workday REST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
This release splits Source Workday into two separate connectors - Source Workday (for RaaS streams) and Source Workday REST (for REST streams). | ||
The connector you're currently using is deprecating REST streams and will continue to support only RAAS streams. REST streams will be available in the new Source Workday REST. | ||
|
||
Action required only if you were using this source to sync REST streams (REST authentication on Setup Page). In that case, you will need to disable this connection and create a new connection using new Source Workday REST. Otherwise, simply upgrade this source to v1.0.0 and continue syncing RaaS streams as usual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
- Workday hostname - The endpoint for connecting into your Workday environment. This can be found by logging into your Workday instance and searching βPublic Web Serviceβ in the search bar and selecting the appropriate report. Use the ellipse (...) button to select **Web Service > View WSDL** | ||
- Access token - An OAuth 2.0 access token for API client integrations. More information and instructions can be found in the Workday community documentation for your environment about creating and registering a Workday API Client. If you are using Airbyte Teams, when registering the API Client for Airbyte, you can use https://cloud.airbyte.com/auth_flow for the Redirection URI field . If you are using Self-Managed Enterprise, you can use the URL of your Airbyte deployment instead. | ||
|
||
## Setup Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Headings] 'Setup Guide' should use sentence-style capitalization.
2. Click Sources and then click **+ New source**. | ||
3. On the Set up the source page, select Workday REST. | ||
4. Enter a name for the Workday connector. | ||
5. Enter the Tenant and Hostname for your Workday environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π« [vale] reported by reviewdog πΆ
[Vale.Spelling] Did you really mean 'Hostname'?
4. Enter a name for the Workday connector. | ||
5. Enter the Tenant and Hostname for your Workday environment. | ||
6. Enter the access token. | ||
7. **Start Date (Optional)** is the earliest date for data that will be synced. If a date is not specified, all data from the last 2 years will be synced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
4. Enter a name for the Workday connector. | ||
5. Enter the Tenant and Hostname for your Workday environment. | ||
6. Enter the access token. | ||
7. **Start Date (Optional)** is the earliest date for data that will be synced. If a date is not specified, all data from the last 2 years will be synced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
- Worker Payslips | ||
- Worker Time Off Entries | ||
|
||
## Supported Streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Headings] 'Supported Streams' should use sentence-style capitalization.
## What <!-- * Describe what the change is solving. Link all GitHub issues related to this change. --> This PR adds support for migration guides on enterprise connectors. <img width="1920" height="883" alt="image" src="https://github.com/user-attachments/assets/8a94d7a7-e390-4460-900c-bfaf000e6f0b" /> ## How <!-- * Describe how code changes achieve the solution. --> Updated filtering logic to support top-level `id` as well as nested `link.id`. The existing filtering logic for enterprise connectors in the sidebar did not expect nested migration guides. The reason is because the getFilenamesInDir() function returns two different object structures. Simple doc (no migration file): { type: "doc", id: "...", label: "..." } - has id at top level Category with migration doc: { type: "category", label: "...", link: { id: "..." }, items: [...] } - has id nested in link.id @darynaishchenko discovered during work on #67214 that all builds failed when a migration guide was added to an enterprise connector. ## Review guide 1. Review the logic in the sidebar filtering code. 2. There is currently no migration guide in master to test this on, but I did test this fix with Darnya's PR and it built correctly with the updated code. You can simulate a migration guide by adding a dummy `<connector_filename>-migrations.md` doc for an enterprise connector. At build time it should nest appropriately under its parent object. ## User Impact <!-- * What is the end result perceived by the user? * If there are negative side effects, please list them. --> Enterprise customers can have migration guides too. ## Can this PR be safely reverted and rolled back? <!-- * If unsure, leave it blank. --> - [x] YES π - [ ] NO β
What
Updates docs for source workday and source workday rest changes added in this pr
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?