Skip to content

fix(source-google-ads): prevent StreamSlice mutation to fix cursor validation error #67591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(source-google-ads): prevent StreamSlice mutation to fix cursor validation error #67591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
418f3d6
fix(source-google-ads): prevent StreamSlice mutation to fix cursor va…
devin-ai-integration[bot] Oct 9, 2025
6ccbd79
chore(source-google-ads): bump version to 4.1.0-rc.7
devin-ai-integration[bot] Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
dockerImageTag: "4.1.0-rc.6"
dockerImageTag: "4.1.0-rc.7"
dockerRepository: airbyte/source-google-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/google-ads
githubIssueLabel: source-google-ads
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "4.1.0-rc.6"
version = "4.1.0-rc.7"
name = "source-google-ads"
description = "Source implementation for Google Ads."
authors = [ "Airbyte <[email protected]>",]
Expand Down
3 changes: 2 additions & 1 deletion airbyte-integrations/connectors/source-google-ads/source_google_ads/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ def _read_pages(

# Update the stream slice start time to the last record's cursor
last_cursor = last_record[self.cursor_field]
cursor_slice = stream_slice.cursor_slice
cursor_slice = dict(stream_slice.cursor_slice)
cursor_slice["start_time"] = last_cursor
stream_slice = StreamSlice(
partition=stream_slice.partition,
Expand Down Expand Up @@ -531,6 +531,7 @@ def _read_pages(
"deleted_at": ts,
},
stream_name=self.name,
associated_slice=stream_slice,
)
else:
updated_ids.append(_id)
Expand Down
2 changes: 2 additions & 0 deletions docs/integrations/sources/google-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,8 @@ Due to a limitation in the Google Ads API which does not allow getting performan

| Version | Date | Pull Request | Subject |
|:------------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 4.1.0-rc.7 | 2025-10-09 | [67591](https://github.com/airbytehq/airbyte/pull/67591) | Fix StreamSlice mutation causing cursor validation errors |

| 4.1.0-rc.6 | 2025-09-25 | [66701](https://github.com/airbytehq/airbyte/pull/66701) | Enables progressive rollouts |
| 4.1.0-rc.5 | 2025-09-25 | [66569](https://github.com/airbytehq/airbyte/pull/66569) | Bumps to CDK v7, adds retry/backoff logic to custom schema loader |
| 4.1.0-rc.4 | 2025-09-18 | [66522](https://github.com/airbytehq/airbyte/pull/66522) | Revert to CDK v6.60.12 |
Expand Down
Loading