-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ci: run cdk compatibility test only on certified connectors #67604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
- name: List certified connectors | ||
id: list-connectors | ||
run: | | ||
json_array=$(tools/bin/bulk-cdk-auto-upgrade/list-connectors-to-upgrade.sh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed where the script lives since it is now being used not only in the auto-upgrade context
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 | ||
with: | ||
submodules: true # Needed for airbyte-enterprise connectors (no-op otherwise) | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this now since we are not using a git diff to know which connectors changed
- name: Generate Connector Matrix | ||
id: generate-matrix | ||
run: echo "connectors_matrix=$(./poe-tasks/get-modified-connectors.sh --json --local-cdk)" | tee -a $GITHUB_OUTPUT | ||
run: echo "connectors_matrix=$(tools/bin/bulk-cdk/get-certified-connectors.sh)" | tee -a $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reuse auto bump script
What
The existing
CDK Connector Compatibility Test
workflow currently tests all connectors using the bulk CDK. However, we only want to test certified connectors. This PR modifies the workflow to run tests exclusively on certified connectors using the CDK.How
Instead of getting the list of connectors to test from the diff generated by running a CDK upgrade task, we will get the list of certified connectors by reusing the script used in the auto bump workflow to get this information.
How did I test this?
Tested it in this PR. More specifically, here's the PR check run https://github.com/airbytehq/airbyte/actions/runs/18410594109/job/52461620803?pr=67605
Note: it looks like the connectors we are testing didn't change. I'd guess it is possible that in the future we will have some none certified connectors using the cdk so the change in this PR still makes sense.
Can this PR be safely reverted and rolled back?