Skip to content

fix(source-github): Resolve duplicate field errors for +1/-1 reaction columns in Parquet/Avro destinations #67609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(source-github): Resolve duplicate field errors for +1/-1 reaction columns in Parquet/Avro destinations #67609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3d0ad8
fix(source-github): Resolve duplicate field errors for +1/-1 reaction…
devin-ai-integration[bot] Oct 10, 2025
0df6ab2
fix(source-github): Add changelog entry and update version to 1.9.1-r…
devin-ai-integration[bot] Oct 10, 2025
3f3429c
fix(source-github): Update version to 1.9.0-rc.4 to maintain rc series
devin-ai-integration[bot] Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions airbyte-integrations/connectors/source-github/integration_tests/expected_records.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-github/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: ef69ef6e-aa7f-4af1-a01d-ef775033524e
dockerImageTag: 1.9.0-rc.3
dockerImageTag: 1.9.0-rc.4
dockerRepository: airbyte/source-github
documentationUrl: https://docs.airbyte.com/integrations/sources/github
erdUrl: https://dbdocs.io/airbyteio/source-github?view=relationships
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-github/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "1.9.0-rc.3"
version = "1.9.0-rc.4"
name = "source-github"
description = "Source implementation for GitHub."
authors = [ "Airbyte <[email protected]>",]
Expand Down Expand Up @@ -45,4 +45,4 @@ include = [
test-unit-tests.shell = '''
poetry run pytest --junitxml=build/test-results/pytest-unit-tests-junit.xml --ignore=unit_tests/integration/ unit_tests
poetry run pytest --junitxml=build/test-results/pytest-unit-integration-tests-junit.xml unit_tests/integration/
'''
'''
4 changes: 2 additions & 2 deletions ...te-integrations/connectors/source-github/source_github/schemas/shared/events/comment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@
"properties": {
"url": { "type": "string" },
"total_count": { "type": "integer" },
"+1": { "type": "integer" },
"-1": { "type": "integer" },
"plus_one": { "type": "integer" },
"minus_one": { "type": "integer" },
"laugh": { "type": "integer" },
"confused": { "type": "integer" },
"heart": { "type": "integer" },
Expand Down
4 changes: 2 additions & 2 deletions ...-integrations/connectors/source-github/source_github/schemas/shared/events/commented.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@
"properties": {
"url": { "type": "string" },
"total_count": { "type": "integer" },
"+1": { "type": "integer" },
"-1": { "type": "integer" },
"plus_one": { "type": "integer" },
"minus_one": { "type": "integer" },
"laugh": { "type": "integer" },
"confused": { "type": "integer" },
"heart": { "type": "integer" },
Expand Down
8 changes: 4 additions & 4 deletions ...ations/connectors/source-github/source_github/schemas/shared/events/cross_referenced.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,10 +752,10 @@
"total_count": {
"type": "integer"
},
"+1": {
"plus_one": {
"type": "integer"
},
"-1": {
"minus_one": {
"type": "integer"
},
"laugh": {
Expand Down Expand Up @@ -788,10 +788,10 @@
"total_count": {
"type": "integer"
},
"+1": {
"plus_one": {
"type": "integer"
},
"-1": {
"minus_one": {
"type": "integer"
},
"laugh": {
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-github/source_github/schemas/shared/reactions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"total_count": {
"type": ["null", "integer"]
},
"+1": {
"plus_one": {
"type": ["null", "integer"]
},
"-1": {
"minus_one": {
"type": ["null", "integer"]
},
"laugh": {
Expand Down
8 changes: 8 additions & 0 deletions airbyte-integrations/connectors/source-github/source_github/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,14 @@ def get_error_display_message(self, exception: BaseException) -> Optional[str]:

def transform(self, record: MutableMapping[str, Any], stream_slice: Mapping[str, Any]) -> MutableMapping[str, Any]:
record["repository"] = stream_slice["repository"]

if "reactions" in record and record["reactions"]:
reactions = record["reactions"]
if "+1" in reactions:
reactions["plus_one"] = reactions.pop("+1")
if "-1" in reactions:
reactions["minus_one"] = reactions.pop("-1")

return record

def parse_response(
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ Your token should have at least the `repo` scope. Depending on which streams you
|:-----------|:-----------|:------------------------------------------------------------------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 1.9.0-rc.3 | 2025-10-09 | [67589](https://github.com/airbytehq/airbyte/pull/67589) | Fix min time to wait on token rate limits |
| 1.9.0-rc.2 | 2025-10-03 | [67026](https://github.com/airbytehq/airbyte/pull/67026) | Fix converting datetime in workflows stream |
| 1.9.0-rc.4 | 2025-10-10 | [67609](https://github.com/airbytehq/airbyte/pull/67609) | Fix duplicate field errors for reaction columns +1/-1 in Parquet/Avro destinations |
| 1.9.0-rc.1 | 2025-10-02 | [66736](https://github.com/airbytehq/airbyte/pull/66736) | Update to airbyte-cdk v^7 |
| 1.8.42 | 2025-09-30 | [66166](https://github.com/airbytehq/airbyte/pull/66166) | Update dependencies |
| 1.8.41 | 2025-09-09 | [66065](https://github.com/airbytehq/airbyte/pull/66065) | Update dependencies |
Expand Down
Loading