Skip to content

Conversation

frifriSF59
Copy link
Contributor

What

This should fix the User character length limit (16777216) exceeded by string error

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

Copy link
Contributor

πŸ‘‹ Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

πŸ“ Edit this welcome message.

Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Could we add a unit test to the SnowflakeValueCoercerTest that validates that the length limit is checked?

Copy link
Contributor

github-actions bot commented Oct 10, 2025

destination-snowflake Connector Test Results

 24 files   24 suites   13m 21s ⏱️
284 tests 252 βœ…β€ƒ32 πŸ’€β€ƒ0 ❌
288 runsβ€Šβ€ƒ256 βœ…β€ƒ32 πŸ’€β€ƒ0 ❌

Results for commit 6927c9f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 10, 2025

Deploy preview for airbyte-docs ready!

βœ… Preview
https://airbyte-docs-93k0s1kyd-airbyte-growth.vercel.app

Built with commit 6927c9f.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@tryangul tryangul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some comments could use cleaned up and some tests should be added. I had some fixes for the AI generated ones in my branch you might want to steal.

@frifriSF59 frifriSF59 merged commit 0f6a500 into master Oct 10, 2025
34 checks passed
@frifriSF59 frifriSF59 deleted the frifri/snstringlnfixc branch October 10, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants