-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[Snowflake] Fix string length char size issue #67610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
π Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a unit test to the
SnowflakeValueCoercerTest
that validates that the length limit is checked?
|
Deploy preview for airbyte-docs ready! β
Preview Built with commit 6927c9f. |
...otlin/io/airbyte/integrations/destination/snowflake/write/transform/SnowflakeValueCoercer.kt
Outdated
Show resolved
Hide resolved
...otlin/io/airbyte/integrations/destination/snowflake/write/transform/SnowflakeValueCoercer.kt
Show resolved
Hide resolved
...otlin/io/airbyte/integrations/destination/snowflake/write/transform/SnowflakeValueCoercer.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM some comments could use cleaned up and some tests should be added. I had some fixes for the AI generated ones in my branch you might want to steal.
What
This should fix the
User character length limit (16777216) exceeded by string
errorCan this PR be safely reverted and rolled back?