ci: make cdk connector compatibility test create gh issue #67611
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
| id: check-move-notify | ||
| if: always() | ||
| run: | | ||
| echo "should-notify=${{ |
There was a problem hiding this comment.
setting condition here so that I don't repeat it everywhere
| working-directory: airbyte-integrations/connectors/${{ matrix.connector }} | ||
| run: poe test-integration-tests | ||
|
|
||
| - name: Check if move team should be notified |
There was a problem hiding this comment.
note that this is only to notify the move team. The logic to create a gh issue changes quite a bit depending on how teams manage their oncall tickets so I thought it made sense to just do it for the ones we own (and also by doing this we are not making other team sign up to how we want to deal with these issues).
| token: ${{ secrets.SLACK_BOT_TOKEN_AIRBYTE_TEAM }} | ||
| method: chat.postMessage | ||
| payload: | | ||
| channel: C09H56MT8J2 # jose-alert-test channel. The use of this channel is meant to be temporary while we evaluate the usefulness of these notifications. |
There was a problem hiding this comment.
I renamed the channel to cdk-connector-compatibility-tests
| ISSUES_REPOSITORY="${ISSUES_REPOSITORY:-airbytehq/airbyte-internal-issues}" | ||
| PROJECT_NUMBER="${PROJECT_NUMBER:-98}" | ||
| STATUS_FIELD_ID="${STATUS_FIELD_ID:-PVTSSF_lADOA4_XW84Am4WkzgetXZM}" | ||
| ONCALL_OPTION_ID="${ONCALL_OPTION_ID:-3ecf8bb4}" |
There was a problem hiding this comment.
using all these ids is not pretty, but afaik this is the only way to deal creating issues and editing their fields
There was a problem hiding this comment.
can you add a comment explaining how to find these IDs? I actually don't know where to find them 😅
jpefaur
changed the title
There was a problem hiding this comment.
out of curiosity, definitely not saying you should - did you look at e.g. https://github.com/marketplace/actions/create-issues for the issue creation piece? Or is the stuff around "create if not exists" just too bespoke for anything off the shelf
| ISSUES_REPOSITORY="${ISSUES_REPOSITORY:-airbytehq/airbyte-internal-issues}" | ||
| PROJECT_NUMBER="${PROJECT_NUMBER:-98}" | ||
| STATUS_FIELD_ID="${STATUS_FIELD_ID:-PVTSSF_lADOA4_XW84Am4WkzgetXZM}" | ||
| ONCALL_OPTION_ID="${ONCALL_OPTION_ID:-3ecf8bb4}" |
There was a problem hiding this comment.
can you add a comment explaining how to find these IDs? I actually don't know where to find them 😅
2 participants
What
We have a workflow that once a day checks if the latest CDK version would break any connector. If there are test failures, it sends a slack alert. In addition to sending a slack alert, we would like to get an oncall ticket in our github project. We should only do this for destinations (connectors owned by move)
How
Added a few extra steps to the workflow that calls a script that creates gh issues. It checks if an issue already exists for the connector. If it does it will update the description with information about the new failure. If it doesn't it will create a new ticket
How did I test this?
Tested in this PR #67617. Confirmed that tickets were created if they didn't exist and that they were updated if they did exist.
Can this PR be safely reverted and rolled back?