-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(source-zendesk-support): update CDK with OAuth fix and expires_in 600 for testing (do not merge) #72381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(source-zendesk-support): update CDK with OAuth fix and expires_in 600 for testing (do not merge) #72381
Conversation
… 600 for testing (do not merge) Co-Authored-By: gl_anatolii.yatsuk@airbyte.io <gl_anatolii.yatsuk@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Co-Authored-By: gl_anatolii.yatsuk@airbyte.io <gl_anatolii.yatsuk@airbyte.io>
|
/publish-connectors-prerelease
|
|
Co-Authored-By: gl_anatolii.yatsuk@airbyte.io <gl_anatolii.yatsuk@airbyte.io>
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 6110631. |
What
This PR is for testing the OAuth race condition fix from the prerelease CDK version. It includes a short token expiry time (
expires_in: 600= 10 minutes) to force frequent token refreshes and validate the fix.Related CDK PR: airbytehq/airbyte-python-cdk#883
How
baseImageinmetadata.yamlto prerelease CDK version7.6.5.post3.dev21398747886which includes thread-safe token refresh with double-checked lockingexpires_infrom172800(48 hours) to600(10 minutes) inmanifest.yamlto force frequent token refreshes during testingdockerImageTagfrom5.0.1to5.0.2Review guide
metadata.yaml- CDK version update and version bumpmanifest.yaml-expires_inchange (line 28)User Impact
This is a testing-only PR. The short token expiry would cause excessive token refreshes if deployed to production.
Can this PR be safely reverted and rolled back?
Requested by: gl_anatolii.yatsuk@airbyte.io
Link to Devin run: https://app.devin.ai/sessions/2f784e9440324787893047ac3a1c0fbc