fix(source-shortcut): remove invalid includes_description param from groups stream (AI-Triage PR) #72387
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…groups stream The Shortcut API /groups endpoint does not support the includes_description query parameter, causing a 400 error with 'disallowed-key'. This parameter was incorrectly copied from other streams like /epics and /files that do support it. Fixes: #72386 Co-Authored-By: unknown <>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the
groupsandgroups_storiesstreams failing with HTTP 400 errors due to an invalid query parameter.Resolves: #72386
Internal tracking: https://github.com/airbytehq/oncall/issues/11051
How
Removes the
includes_description=truequery parameter from thegroupsstream definition in the connector manifest. The Shortcut API/groupsendpoint does not support this parameter (returns{"errors": {"includes_description": "disallowed-key"}}), though other endpoints like/epicsand/filesdo support it. This appears to have been a copy-paste error when the connector was originally created.Review guide
airbyte-integrations/connectors/source-shortcut/manifest.yaml- Removal of the invalid request parameterairbyte-integrations/connectors/source-shortcut/metadata.yaml- Version bump 0.0.42 → 0.0.43User Impact
Users will be able to successfully sync the
groupsandgroups_storiesstreams, which were previously failing with 400 errors.Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/0a30e4c3eb044a14abfb4b4f19d1e246
Requested by: AI triage from community report by @clagali-movable