Skip to content

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Oct 3, 2025

At somepoint i moved from the phoenix package, which is huge and contains the full platform, to the standalone packages we need (phoenix-client, phoenix-otel, phoenix-evals)

When I made the package switch, things broke due to slightly different behavior on the phoenix-client package. I didn't notice since locally the old package was still installed.

This updates the syntax to work with the standalone client.

@github-actions github-actions bot added bug Something isn't working security labels Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This Branch via MCP

To test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration:

{
  "mcpServers": {
    "connector-builder-mcp-dev": {
      "command": "uvx",
      "args": ["--from", "git+https://github.com/airbytehq/connector-builder-mcp.git@pedro/fix-evals-async", "connector-builder-mcp"]
    }
  }
}

Testing This Branch via CLI

You can test this version of the MCP Server using the following CLI snippet:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/connector-builder-mcp.git@pedro/fix-evals-async#egg=airbyte-connector-builder-mcp' --help

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poe <command> - Runs any poe command in the uv virtual environment
  • /poe build-connector prompt="Star Wars API" - Run the connector builder using the Star Wars API.

📝 Edit this welcome message.

Copy link

github-actions bot commented Oct 3, 2025

PyTest Results (Fast)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit d2deb66. ± Comparison against base commit e9230df.

@pedroslopez pedroslopez marked this pull request as ready for review October 3, 2025 04:44
@pedroslopez pedroslopez requested a review from Copilot October 3, 2025 04:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes compatibility with the standalone Phoenix client package by updating imports and API calls. The changes migrate from the monolithic phoenix package to the standalone phoenix-client package, which has slightly different API patterns.

  • Replaced synchronous experiment API with async client pattern
  • Updated imports to use standalone package structure
  • Added async/await support for the new client API

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
connector_builder_agents/src/evals/phoenix_run.py Migrated to async Phoenix client API and restructured main execution
connector_builder_agents/src/evals/dataset.py Updated import path for Dataset type to match standalone package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pedroslopez pedroslopez merged commit 559b260 into main Oct 3, 2025
19 checks passed
@pedroslopez pedroslopez deleted the pedro/fix-evals-async branch October 3, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant