-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add agent identity debug logging to expose coordination issues #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add agent identity debug logging to expose coordination issues #132
Conversation
Co-Authored-By: AJ Steers <[email protected]>
Original prompt from AJ Steers
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
📝 WalkthroughWalkthroughUpdates user-facing log messages in agent delegation/handback callbacks and adds iteration_count with per-iteration logging in the manager-developer run loop. Final output logging is split into iteration completion and agent output lines. No public interfaces or control flow are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code graph analysis (1)connector_builder_agents/src/run.py (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (5)
Comment |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This Branch via MCPTo test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration: {
"mcpServers": {
"connector-builder-mcp-dev": {
"command": "uvx",
"args": ["--from", "git+https://github.com/airbytehq/connector-builder-mcp.git@devin/1760131322-add-agent-identity-logging", "connector-builder-mcp"]
}
}
} Testing This Branch via CLIYou can test this version of the MCP Server using the following CLI snippet: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/connector-builder-mcp.git@devin/1760131322-add-agent-identity-logging#egg=airbyte-connector-builder-mcp' --help PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
feat: Add agent identity debug logging to expose coordination issues
Summary
Adds explicit agent identity logging at key coordination points in the manager-developer orchestration system. This diagnostic change helps identify agent identity confusion issues where agents lose track of their role during handoffs and iterations.
Changes:
agents.py
with directional indicators[MANAGER → DEVELOPER]
and[DEVELOPER → MANAGER]
run.py
This addresses debugging needs identified in investigation of PR #122 execution logs where developer agents exhibited manager-like behavior (attempting to delegate tasks).
Review & Testing Checklist for Human
Notes
These changes are diagnostic only - they expose coordination issues but don't fix the underlying root causes (commented-out
previous_response_id
and completion signaling issues). Those fixes are being addressed in separate PRs.Requested by: @aaronsteers
Session: https://app.devin.ai/sessions/6acb99e3b34a4918af907764ca9b55c3
Summary by CodeRabbit