-
Notifications
You must be signed in to change notification settings - Fork 2
feat: improved llm docs and guidance, add execute_record_counts_smoke_test
#19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mic_manifest_resolution_test'; chore: update chatmode for testing
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This Branch via MCPTo test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration: {
"mcpServers": {
"connector-builder-mcp-dev": {
"command": "uvx",
"args": ["--from", "git+https://github.com/airbytehq/connector-builder-mcp.git@feat/improved-llm-docs-and-guidance", "connector-builder-mcp"]
}
}
} Testing This Branch via CLIYou can test this version of the MCP Server using the following CLI snippet: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/connector-builder-mcp.git@feat/improved-llm-docs-and-guidance#egg=airbyte-connector-builder-mcp' --help PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request improves LLM documentation and guidance for the Connector Builder MCP by restructuring guidance into a dedicated module, adding new testing tools, and expanding documentation access.
- Extracted guidance constants and topic mappings into a dedicated
_guidance.py
module - Added multi-stream smoke testing functionality with comprehensive record counting
- Enhanced manifest resolution with dynamic stream detection capabilities
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
connector_builder_mcp/_guidance.py | New module containing guidance constants, topic mappings, and overview prompts |
connector_builder_mcp/_connector_builder.py | Added smoke testing tools, improved manifest resolution, and refactored to use guidance module |
connector_builder_mcp/server.py | Registered new connector search tools |
tests/test_integration.py | Updated imports to use TOPIC_MAPPING from guidance module |
.vscode/mcp.json | Added development configuration with debugging support |
.github/chatmodes/connector-builder-mcp-test-mode.chatmode.md | New chat mode configuration for testing |
execute_record_counts_smoke_test
…references - Remove import and registration of deleted _connector_search module from server.py - Update tests to use execute_dynamic_manifest_resolution_test instead of get_resolved_manifest - Update test assertions to match new documentation format in PR #19 - Skip URL accessibility tests for non-existent branch references - Fixes CI failures in MyPy and pytest suites Resolves import errors and test failures blocking PR #19 merge readiness. Co-Authored-By: AJ Steers <[email protected]>
No description provided.