Skip to content

Conversation

aaronsteers
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 17:56
@github-actions github-actions bot added the enhancement New feature or request label Aug 7, 2025
Copy link

github-actions bot commented Aug 7, 2025

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This Branch via MCP

To test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration:

{
  "mcpServers": {
    "connector-builder-mcp-dev": {
      "command": "uvx",
      "args": ["--from", "git+https://github.com/airbytehq/connector-builder-mcp.git@feat/improved-llm-docs-and-guidance", "connector-builder-mcp"]
    }
  }
}

Testing This Branch via CLI

You can test this version of the MCP Server using the following CLI snippet:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/connector-builder-mcp.git@feat/improved-llm-docs-and-guidance#egg=airbyte-connector-builder-mcp' --help

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poe <command> - Runs any poe command in the uv virtual environment

📝 Edit this welcome message.

Copy link

github-actions bot commented Aug 7, 2025

PyTest Results (Fast)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 13002c0. ± Comparison against base commit 8954e30.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 7, 2025

PyTest Results (Full)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 13002c0. ± Comparison against base commit 8954e30.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves LLM documentation and guidance for the Connector Builder MCP by restructuring guidance into a dedicated module, adding new testing tools, and expanding documentation access.

  • Extracted guidance constants and topic mappings into a dedicated _guidance.py module
  • Added multi-stream smoke testing functionality with comprehensive record counting
  • Enhanced manifest resolution with dynamic stream detection capabilities

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
connector_builder_mcp/_guidance.py New module containing guidance constants, topic mappings, and overview prompts
connector_builder_mcp/_connector_builder.py Added smoke testing tools, improved manifest resolution, and refactored to use guidance module
connector_builder_mcp/server.py Registered new connector search tools
tests/test_integration.py Updated imports to use TOPIC_MAPPING from guidance module
.vscode/mcp.json Added development configuration with debugging support
.github/chatmodes/connector-builder-mcp-test-mode.chatmode.md New chat mode configuration for testing

@aaronsteers aaronsteers changed the title feat: improved llm docs and guidance feat: improved llm docs and guidance, add execute_record_counts_smoke_test Aug 7, 2025
@aaronsteers aaronsteers changed the title feat: improved llm docs and guidance, add execute_record_counts_smoke_test feat: improved llm docs and guidance, add execute_record_counts_smoke_test Aug 7, 2025
devin-ai-integration bot added a commit that referenced this pull request Aug 7, 2025
…references

- Remove import and registration of deleted _connector_search module from server.py
- Update tests to use execute_dynamic_manifest_resolution_test instead of get_resolved_manifest
- Update test assertions to match new documentation format in PR #19
- Skip URL accessibility tests for non-existent branch references
- Fixes CI failures in MyPy and pytest suites

Resolves import errors and test failures blocking PR #19 merge readiness.

Co-Authored-By: AJ Steers <[email protected]>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@aaronsteers aaronsteers merged commit 05730ad into main Aug 7, 2025
13 checks passed
@aaronsteers aaronsteers deleted the feat/improved-llm-docs-and-guidance branch August 7, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant