-
Notifications
You must be signed in to change notification settings - Fork 2
feat!: rename find_connectors_by_feature to find_connectors_by_class_name #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename find_connectors_by_feature to find_connectors_by_class_name #27
Conversation
…ture descriptions - Updated docstring to explain tool searches for exact class names - Added examples of valid class names (DynamicDeclarativeStream, HttpComponentsResolver, etc.) - Clarified parameter description to specify class name format requirements - Emphasized difference between class names vs feature descriptions Co-Authored-By: AJ Steers <[email protected]>
…name BREAKING CHANGE: Function renamed from find_connectors_by_feature to find_connectors_by_class_name to better reflect that it expects exact class names, not feature descriptions. - Updated parameter name from 'features' to 'class_names' - Improved documentation with clearer examples of valid class names - Updated internal variable names for consistency - Added examples: DynamicDeclarativeStream, HttpComponentsResolver, etc. - Clarified difference between class names vs feature descriptions Co-Authored-By: AJ Steers <[email protected]>
Original prompt from AJ Steers
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This Branch via MCPTo test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration: {
"mcpServers": {
"connector-builder-mcp-dev": {
"command": "uvx",
"args": ["--from", "git+https://github.com/airbytehq/connector-builder-mcp.git@devin/1754709149-clarify-find-connectors-by-feature-tool-docs", "connector-builder-mcp"]
}
}
} Testing This Branch via CLIYou can test this version of the MCP Server using the following CLI snippet: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/connector-builder-mcp.git@devin/1754709149-clarify-find-connectors-by-feature-tool-docs#egg=airbyte-connector-builder-mcp' --help PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames find_connectors_by_feature
to find_connectors_by_class_name
to better reflect its actual functionality and improve clarity. The function searches for connectors that use specific declarative component class names, not high-level feature descriptions.
- Renamed function and parameter for better semantic clarity
- Enhanced documentation with concrete examples of valid class names
- Updated internal variable names for consistency
feat!: rename find_connectors_by_feature to find_connectors_by_class_name
Summary
This PR renames the
find_connectors_by_feature
function tofind_connectors_by_class_name
and significantly improves its documentation to clarify expectations. The original function name and parameter (features
) were misleading, as the tool actually expects exact class names from the Airbyte declarative component system, not high-level feature descriptions.Key Changes:
find_connectors_by_feature
tofind_connectors_by_class_name
features
toclass_names
feature_list
→class_name_list
, etc.)The function behavior is unchanged - it still searches a CSV index file and returns connectors that use ALL specified class names.
Review & Testing Checklist for Human
Recommended Test Plan:
find_connectors_by_class_name
appearsDynamicDeclarativeStream
,HttpComponentsResolver
,ConfigComponentsResolver
Diagram
Notes
DynamicDeclarativeStream
during developmentImportant
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.