-
Notifications
You must be signed in to change notification settings - Fork 2
feat(mcp): Update tool parameter descriptions for privatebin URL support #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mcp): Update tool parameter descriptions for privatebin URL support #47
Conversation
- Import and use comprehensive DOTENV_FILE_URI_DESCRIPTION constant - Update list_dotenv_secrets parameter description to include privatebin documentation - Update populate_dotenv_missing_secrets_stubs parameter description with privatebin details - Resolve circular import by defining constant locally in _secrets.py - All tests pass and MCP tool testing with privatebin URL successful Co-Authored-By: AJ Steers <[email protected]>
Original prompt from AJ Steers
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This Branch via MCPTo test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration: {
"mcpServers": {
"connector-builder-mcp-dev": {
"command": "uvx",
"args": ["--from", "git+https://github.com/airbytehq/connector-builder-mcp.git@devin/1755831634-fix-privatebin-tool-definitions", "connector-builder-mcp"]
}
}
} Testing This Branch via CLIYou can test this version of the MCP Server using the following CLI snippet: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/connector-builder-mcp.git@devin/1755831634-fix-privatebin-tool-definitions#egg=airbyte-connector-builder-mcp' --help PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
- Move DOTENV_FILE_URI_DESCRIPTION from _secrets.py and connector_builder.py to _guidance.py - Update imports in both consuming modules to use shared constant - Eliminates code duplication while avoiding circular imports - Addresses GitHub comment feedback from @aaronsteers Co-Authored-By: AJ Steers <[email protected]>
✅ Deduplication completed! I've successfully moved the Changes made:
Verification:
The |
- Fix MCP tool parameter name mismatch between function signatures and framework expectations - Update list_dotenv_secrets and populate_dotenv_missing_secrets_stubs parameter names - Remove debug logging added during troubleshooting - All tests still pass with parameter name changes Co-Authored-By: AJ Steers <[email protected]>
- Fix formatting issues identified by CI - Remove debug file - Addresses Ruff Lint Check and Ruff Format Check failures Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
…omatic path processing Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
…str to match working functions Co-Authored-By: AJ Steers <[email protected]>
- FastMCP converts https:// URLs to file paths with missing / - Add detection and correction for /home/ubuntu/https:/ pattern - Fixes privatebin URL detection in MCP tools Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
…tps://github.com/airbytehq/builder-mcp into devin/1755831634-fix-privatebin-tool-definitions
- Remove debug print statements from list_dotenv_secrets and populate_dotenv_missing_secrets_stubs - Remove workaround code that was added for FastMCP framework URL processing issue - Local testing with poe test-tool confirms privatebin URL processing works correctly - Both MCP tools successfully handle https://privatebin.net URLs with proper validation Co-Authored-By: AJ Steers <[email protected]>
- Add Direct Tool Testing section with poe test-tool examples - Document privatebin URL testing with PRIVATEBIN_PASSWORD requirement - Add examples for testing secrets tools with both local files and privatebin URLs - Update unit testing examples to include secrets functionality - Expand common issues and best practices sections - Emphasize local testing workflow for development Co-Authored-By: AJ Steers <[email protected]>
Co-Authored-By: AJ Steers <[email protected]>
Update MCP tool parameter descriptions for privatebin URL support
Summary
This PR updates the public-facing MCP tool parameter descriptions to properly document privatebin URL support that was already implemented in the core functions. The core privatebin functionality was working correctly, but the tool definitions weren't exposing this capability to users through proper documentation.
Key Changes:
list_dotenv_secrets
parameter description to include comprehensive privatebin documentationpopulate_dotenv_missing_secrets_stubs
parameter description with privatebin detailsDOTENV_FILE_URI_DESCRIPTION
constant locally in_secrets.py
Review & Testing Checklist for Human
DOTENV_FILE_URI_DESCRIPTION
constant in_secrets.py
matches the original inconnector_builder.py
(I duplicated it to avoid circular import)Recommended test plan: Run
poe test-tool list_dotenv_secrets
andpoe test-tool populate_dotenv_missing_secrets_stubs
with the test privatebin URL from the test suite to ensure end-to-end functionality works.Diagram
Notes