Skip to content

Conversation

aaronsteers
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Sep 3, 2025

PyTest Results (Fast)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 990e318. ± Comparison against base commit b4ae513.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 3, 2025

PyTest Results (Full)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 990e318. ± Comparison against base commit b4ae513.

♻️ This comment has been updated with latest results.

@aaronsteers aaronsteers requested a review from Copilot September 3, 2025 23:32
@aaronsteers aaronsteers marked this pull request as ready for review September 3, 2025 23:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the secrets handling module by making the load_secrets function private and enhancing its functionality. The changes improve the module's internal structure while adding better support for nested configurations and error handling.

  • Renames load_secrets to _load_secrets to make it a private function
  • Adds support for nested dictionary structures using dot notation in secrets
  • Improves error handling with proper FileNotFoundError exceptions
  • Updates all test files and imports to use the new private function

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
connector_builder_mcp/_secrets.py Core refactoring of secrets loading with nested dict support and improved error handling
tests/test_secrets.py Updates tests to use private function and adds proper fixtures for testing
tests/test_integration.py Updates import to use the new private function name
connector_builder_mcp/manifest_scaffold.py Minor code style improvements with import organization
pyproject.toml Adds metadata configuration for direct references
poe_tasks.toml Adds sandbox directory configuration
README.md Updates configuration examples and removes upgrade flags

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aaronsteers aaronsteers changed the title Aj/chore/fix-secrets-refs fix: secret refs and injection Sep 3, 2025
@aaronsteers aaronsteers changed the title fix: secret refs and injection fix: secret refs and config injection Sep 3, 2025
@github-actions github-actions bot added bug Something isn't working security labels Sep 4, 2025
@aaronsteers aaronsteers merged commit 3d6c3e9 into main Sep 4, 2025
13 checks passed
@aaronsteers aaronsteers deleted the aj/chore/fix-secrets-refs branch September 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant