-
Notifications
You must be signed in to change notification settings - Fork 2
fix: secret refs and config injection #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the secrets handling module by making the load_secrets
function private and enhancing its functionality. The changes improve the module's internal structure while adding better support for nested configurations and error handling.
- Renames
load_secrets
to_load_secrets
to make it a private function - Adds support for nested dictionary structures using dot notation in secrets
- Improves error handling with proper FileNotFoundError exceptions
- Updates all test files and imports to use the new private function
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
connector_builder_mcp/_secrets.py | Core refactoring of secrets loading with nested dict support and improved error handling |
tests/test_secrets.py | Updates tests to use private function and adds proper fixtures for testing |
tests/test_integration.py | Updates import to use the new private function name |
connector_builder_mcp/manifest_scaffold.py | Minor code style improvements with import organization |
pyproject.toml | Adds metadata configuration for direct references |
poe_tasks.toml | Adds sandbox directory configuration |
README.md | Updates configuration examples and removes upgrade flags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.