chore: refactor to remove global state #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When wiring up evals, we want to be able to run multiple "sessions" or connector builds within the same python process. The current structure makes this hard, since we use global variables to keep track of a few things, such as which directory we're writing to.
This PR refactors this "global state" that is relevant for a specific run of the agent into a SessionState that is passed around, in order to be able to call the method to run the agent multiple times within the same python process.
Note: most of this was done by Claude Code
How
session_id
as a parameter to therun_connector_build
method. This is so we can explicitly pass a session ID to better control where things will be stored, allowing us to reference the workspace directory after the fact.