Skip to content

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Sep 25, 2025

Important

Auto-merge enabled.

This PR is set to merge automatically when all requirements are met.

Note

Auto-merge may have been disabled. Please check the PR status to confirm.

@github-actions github-actions bot added bug Something isn't working security labels Sep 25, 2025
@aaronsteers aaronsteers changed the title fix: use .secrets dir within cwd (not parent) fix: use .secrets dir within cwd (not parent) Sep 25, 2025
@aaronsteers aaronsteers enabled auto-merge (squash) September 25, 2025 00:40
Copy link

github-actions bot commented Sep 25, 2025

PyTest Results (Fast)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit e6a2ecc. ± Comparison against base commit b03e56f.

♻️ This comment has been updated with latest results.

@aaronsteers aaronsteers requested a review from Copilot September 25, 2025 00:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a path resolution issue where the .secrets directory was being created in the parent directory instead of the current working directory, and updates the GitHub workflow configuration to trigger on PR synchronization events without path restrictions.

  • Changes the secrets directory path from Path.cwd().parent to Path.cwd()
  • Modifies the GitHub workflow to run on PR synchronize events and removes path filtering

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
connector_builder_agents/src/_util.py Fixes secrets directory path to use current working directory instead of parent
.github/workflows/deptry-dependency-analysis.yml Updates workflow triggers and removes path-based filtering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aaronsteers aaronsteers merged commit 0285c5b into main Sep 26, 2025
15 of 16 checks passed
@aaronsteers aaronsteers deleted the aj/fix/use-secrets-dir-within-cwd branch September 26, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant