fix: preserve firefoxId from dynamically detected extensions #942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Firefox extension detection for dynamically detected wallet extensions by properly preserving the
firefoxIdproperty throughout the SDK.The Problem:
When a browser extension responds to the SDK's ping message with a
firefoxIdin the sender object (indicating it's a Firefox extension), the SDK was not preserving this property. This caused the "Use Extension" button to fail on Firefox because the SDK couldn't identify the extension properly.Changes:
firefoxIdoptional property to theExtensioninterfacefirefoxIdfrom pong responses inlistenForExtensions()mergeWallets()to use explicitfirefoxIdproperty from detected extensionsfirefoxIdfor dynamically detected extensionssetInstallState()to show install screen for extension-only walletsTest plan
firefoxIdin pong responsefirefoxIdcontinue to work