Skip to content

Free runtime tmpfs before daemon-reload to unblock bookworm upgrades #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d4rken merged 1 commit into from
May 21, 2026
Merged

Free runtime tmpfs before daemon-reload to unblock bookworm upgrades #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/update-airplanes-rootfs-smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,19 @@ assert_success_state() {
|| fail "release-channel = $(cat "$ROOT_DIR/etc/airplanes/release-channel"), want $expected_release_channel"
assert_contains "$TAR1090_LOG" '^tar1090 install$'
assert_contains "$COMMAND_LOG" '^apt-get install '
# Pre-flight before daemon-reload: stop collectd to free runtime tmpfs
# space so systemd's 16M safety buffer does not abort daemon-reload on
# bookworm Pi-OS feeders. Pins the behavior so the pre-flight cannot
# silently regress. The stub returns 0 for is-active so stop is always
# invoked under the test. Order matters — stop must precede reload.
assert_contains "$COMMAND_LOG" '^systemctl is-active --quiet collectd$'
assert_contains "$COMMAND_LOG" '^systemctl stop collectd$'
local stop_line reload_line
stop_line="$(grep -n '^systemctl stop collectd$' "$COMMAND_LOG" | head -1 | cut -d: -f1)"
reload_line="$(grep -n '^systemctl daemon-reload$' "$COMMAND_LOG" | head -1 | cut -d: -f1)"
if [[ -z "$stop_line" || -z "$reload_line" || "$stop_line" -ge "$reload_line" ]]; then
fail "expected 'systemctl stop collectd' before 'systemctl daemon-reload' (stop=${stop_line:-missing}, reload=${reload_line:-missing})"
fi
assert_contains "$COMMAND_LOG" '^systemctl daemon-reload$'
assert_contains "$COMMAND_LOG" '^systemctl enable airplanes-first-run.service readsb.service airplanes-mlat.service airplanes-feed.service pingfail.service$'
assert_contains "$COMMAND_LOG" '^systemctl mask autogain1090.timer$'
Expand Down
14 changes: 14 additions & 0 deletions update-airplanes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,20 @@ fi
rm -f "$(airplanes_path /etc/systemd/system/dhcpcd.service.d/wait.conf)"


# Pre-flight: systemd refuses `daemon-reload` when the runtime tmpfs has
# less than ~16M free (a safety buffer added in v249). On bookworm Pi-OS
# feeders the runtime tmpfs defaults to ~43M and graphs1090's collectd
# can occupy ~34M of it via its in-memory RRD cache, which drops us
# below the safety buffer. With `set -e`, the daemon-reload failure
# would abort the entire upgrade (no feed bridge, no service enables).
# Stop collectd to free its runtime cache; this script reboots at its
# tail so collectd auto-starts on next boot — no explicit restart
# needed. No-op when collectd is absent (manual / non-graphs1090
# installs).
if systemctl is-active --quiet collectd 2>/dev/null; then
systemctl stop collectd || true
fi

systemctl daemon-reload

# enable services
Expand Down