chore(migrations): drop unneeded altitude bare-metres migrator#104
Merged
Conversation
The defensive converter in _config_sync_build_payload already runs every outbound ALTITUDE value through altitude_to_bare_metres on the wire, so suffixed disk values still emit a clean JSON number to the website regardless of the on-disk shape. The only population that would have benefited from the on-disk rewrite is a single dev-channel feeder, which does not justify the added migration-chain complexity. Removes the migrator, its bats coverage, and the configure-validators.sh source that update.sh only carried for the migrator's sake. Addresses #101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defensive converter in
_config_sync_build_payloadalready runs every outbound ALTITUDE value throughaltitude_to_bare_metreson the wire, so suffixed disk values still emit a clean JSON number to the website regardless of the on-disk shape. The only population that would have benefited from the on-disk rewrite is a single dev-channel feeder, which does not justify the added migration-chain complexity. This drops the migrator, its bats coverage, and theconfigure-validators.shsource thatupdate.shonly carried for the migrator's sake.Addresses #101