fix(claim): clarify ambiguous "Version:" line in CLI output#111
Merged
Conversation
Bare 'Version: N' from apl-feed claim show and apl-feed backup --check is ambiguous with software, image, schema, and API versioning. Rename to 'Secret version' so the value bonds to the Claim secret line above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Version:line printed byapl-feed claim showandapl-feed restore --checkis the claim-secret rotation version, but the bare label collides with feed software, image, schema, and API versioning concepts. A user landing on the output cannot tell which "version" is being shown.Rename it to
Secret version:so the value visually bonds to theClaim secret:line above it and matches how the same field is named inapl-feed status --json(.claim.version) and the backup JSON (.claim.version).