Fix DNS race at boot: wait for network-online.target in feed and mlat units#113
Merged
Conversation
Both daemons open outbound connections to feed.airplanes.live and need DNS to be ready. network.target only guarantees the networking subsystem is initialised, not that a resolver is reachable. Switching to network-online.target matches what airplanes-claim, airplanes-config-sync, and airplanes-diagnostics already declare.
d4rken
force-pushed
the
fix/network-online-ordering
branch
from
b58bffb to
b8c9492
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
airplanes-feedandairplanes-mlatmake outbound connections tofeed.airplanes.liveand need DNS to be reachable before they start.network.targetonly signals that the networking subsystem is initialised — it does not wait for a resolver. The result at boot is a burst of "Temporary failure in name resolution" log entries before the daemon self-recovers.Switching to
network-online.targetmatches whatairplanes-claim,airplanes-config-sync, andairplanes-diagnosticsalready declare. On this image NetworkManager-wait-online is already pulled into boot by the claim service, so there is no added boot delay.