Require installed update.sh only on the legacy contract#116
Merged
Conversation
update.sh self-installs to IPATH on any install path that runs it. The overlay-managed new image does not ship it (not staged, not a managed_paths entry); overlay feeders update via the runtime-overlay orchestrator and update.sh refuses to run there via the overlay guard. The boot smoke was only passing this assertion because it used to run update.sh during the smoke. Scope it to the legacy contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boot-smoke harness required an installed
/usr/local/share/airplanes/update.shon every image contract.update.shself-installs to that path on any install that runs it, so the assertion only passed on the new contract because the smoke used to runupdate.shitself. The overlay-managed image deliberately omitsupdate.sh— it's neither staged into the overlay tree nor a managed-paths entry, overlay feeders update via the runtime-overlay orchestrator, andupdate.shrefuses to run on an overlay-managed root anyway. With the overlay guard correctly stopping that invocation, the new-contract boot smoke fails on a file the image never ships.Scope the assertion to the legacy contract, alongside the other legacy-only install artifacts. A full pass over
assert_image_contractsagainst the overlay image's managed paths and staging confirms this is the last assertion that was only satisfied byupdate.shrunning during the smoke; every other path is overlay-symlinked, image-baked, or generated at first boot.