Push diagnostics right after a feeder is claimed#119
Merged
Conversation
On the first tick where the server reports the feeder account-owned, config-sync records the verdict in its runtime state file and starts one diagnostics push — so a freshly claimed feeder's dashboard shows data within ~60s, not after the next 10-min tick. Only on the unowned->owned edge; skipped under --root and when systemctl is unavailable.
d4rken
force-pushed
the
feat/diag-push-on-claim
branch
from
ac8d2f3 to
9e98b6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A feeder pushes its diagnostics on a 10-minute timer, so right after an owner claims a feeder on the website their dashboard could sit empty for up to ten minutes, waiting for the next push.
When remote configuration is enabled, config sync already learns from the server the moment a feeder becomes account-owned. It now records that ownership in its runtime state file and, on the transition from unowned to owned, starts a single diagnostics push so the dashboard fills in within about a minute. The push is best-effort and skipped on non-host roots and where systemctl isn't available; the diagnostics service still decides for itself whether reporting is enabled.