Add airplanes-feed to video group so vcgencmd reads /dev/vchiq#82
Merged
Conversation
airplanes-diagnostics.service runs as airplanes-feed and calls vcgencmd get_throttled to populate the pi_health.throttle keys. /dev/vchiq is root:video, so without supplementary membership the call silently fails and the keys come through null. Gate on vcgencmd presence + video group existence so the membership lands only where it will be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
airplanes-feeduser runsairplanes-diagnostics.service, which callsvcgencmd get_throttledto populate thepi_health.throttleblock in the diagnostics push./dev/vchiqis ownedroot:video, so without supplementary group membership the call silently fails and the eight throttle keys come throughnull.ensure_airplanes_feed_accountnow adds the user to thevideogroup during account setup, gated on bothvcgencmdbeing installed and thevideogroup existing. The cascade and idempotence guards mirror the existing daemon-group repair path. No-op on hosts without raspi-utils.