Don't report an empty aggregator set as a failed restore#101
Merged
Conversation
Restoring a backup made on a feeder with no third-party aggregators reported the aggregators section as failed and raised a "some items couldn't be restored" warning, even though the restore succeeded. The import helper rejects an empty set with the same code it uses for real errors, so an empty set now short-circuits to a skip before the helper runs. Malformed or non-empty sections still go through the helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a backup taken on a feeder with no third-party aggregators — the common case — reported the aggregators section as failed and surfaced a "some items couldn't be restored" warning, even though the restore had fully succeeded. The backup intentionally records an empty aggregator set, but the import helper rejects an empty set with the same error code it uses for genuine failures, so that empty section was mistaken for an error.
An empty aggregator set now short-circuits to a skip before the import helper runs, so a clean restore reads as clean. Only a well-formed, genuinely-empty backup is skipped; malformed or populated sections still go through the helper, which owns structural validation.