Drop standalone aggregator backup, covered by combined device backup#103
Merged
Conversation
The aggregator page carried its own back-up/restore card and a pair of export/import endpoints. The combined device backup already captures and restores the aggregator sign-in details (sharing keys included) as one of its sections via the same helper verbs, so the standalone path was a redundant second route to the same data. Remove the card, its two routes and handlers, and their tests; the helper argv, sudoers grant, and argv parity stay because the combined backup still uses them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third-party aggregator page carried its own "Back up & restore" card backed by a dedicated pair of export/import endpoints. The combined device backup already captures and restores the aggregator sign-in details (including sharing keys) as one of its sections, using the same underlying helper, so the standalone card was a redundant second path to the same data.
This removes the standalone card, its two routes and handlers, and the tests that covered them. The aggregator export/import helper verbs, the sudoers grant, and the privileged-argv parity all stay in place — the combined backup still uses them. Backing up or restoring aggregator credentials now goes through the device-wide Backup & restore page, which can already select the aggregators section on its own.