Make Wi-Fi changes fast and fix the false adopt failure#58
Merged
Conversation
On the feeder `nmcli connection reload` takes ~11-15s (NetworkManager's netplan integration regenerates everything), so every Wi-Fi change was slow and adopt (~32s) outran the reverse-proxy timeout into a false "adopt failed". Loading just the changed keyfile is ~100ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding, editing, removing, or adopting a Wi-Fi network could take many seconds on a feeder — and adopting one could take long enough that the page reported "adopt failed" even though it had actually worked.
Each change was reloading every saved network, which is slow on this hardware; this loads only the network that changed instead. Wi-Fi changes now finish in well under a second (a couple of seconds for adopt), and the false failure is gone.