Always pass python version when creating mamba/conda env #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jder
commented
May 12, 2025
| @@ -36,7 +36,7 @@ | |||
| from asv.plugins.conda import _find_conda | |||
|
|
|||
| # Two Python versions for testing | |||
| PYTHON_VER1, PYTHON_VER2 = '3.8', platform.python_version() | |||
| PYTHON_VER1, PYTHON_VER2 = '3.8', ".".join(platform.python_version_tuple()[:2]) | |||
There was a problem hiding this comment.
This is somewhat unrelated but I couldn't make tests pass locally with the previous code, since my local version (3.12.10) was not resolvable by mamba. Seems like this makes more sense anyway? Happy to revert or break out if you prefer.
|
This now has conflicts |
jder
force-pushed
the
always-pass-python-version
branch
from
0d44656 to
1ce4c24
Compare
|
@mattip rebased, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have no environment file, we weren't passing a python version constraint after #1444. We now create one if the user did not specify an environment file.
Fixes #1486.