MAINT: Enforce ruff/pyupgrade rules (UP)

[DimitriPapadopoulos]

The CI failure seems unrelated:

=========================== short test summary info ============================
FAILED test/test_run.py::test_run_spec - Failed: Timeout (>300.0s) from pytest-timeout.
============ 1 failed, 159 passed, 94 skipped in 1488.70s (0:24:48) ============

Maybe related to:

asv/.github/workflows/ci_win.yml

Line 36 in d5f068b

python.exe -m pytest -v -l -x --timeout=300 --durations=100 test --environment-type=virtualenv

asv/.github/workflows/triggered.yml

Line 60 in d5f068b

run: ASV_RUNNER="$(pwd)/latest_asv_runner" python -m pytest -v --timeout=300 --webdriver=ChromeHeadless --durations=100 test

PyPy runs might need a higher timeout than 300.

[mattip]

Hmm, is there a way to leave this? The implicit for loop is tricky here.

[DimitriPapadopoulos]

Do you mean this change breaks the code? Both version should be functionally equivalent; yield from is more efficient.

I can add noqa: UP028 if you insist on keeping the loop.

EDIT: Actually, I don't know about the efficiency of yield from, the rationale from UP028 is:

If a for loop only contains a yield statement, it can be replaced with a yield from expression, which is more concise and idiomatic.

EDIT: It's marginally faster when the inputs are long enough: In Python is faster using "yield from" than yield in a loop?

[DimitriPapadopoulos]

I've reverted this change and disabled rule UP028.

[mattip]

Is there a way to leave the explicit loop?

[DimitriPapadopoulos]

I can add noqa: UP028 as well.

But what's wrong with yield from?