MAINT: Enforce ruff/pyupgrade rules (UP) #1501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
May 22, 2025
| @@ -23,8 +23,7 @@ def benchmark_param_iter(benchmark): | |||
| if not benchmark['params']: | |||
| yield None, () | |||
| else: | |||
| for item in enumerate(itertools.product(*benchmark['params'])): | |||
| yield item | |||
| yield from enumerate(itertools.product(*benchmark['params'])) | |||
There was a problem hiding this comment.
Hmm, is there a way to leave this? The implicit for loop is tricky here.
There was a problem hiding this comment.
Do you mean this change breaks the code? Both version should be functionally equivalent; yield from is more efficient because the loop is implemented inside Python itself.
I can add noqa: UP028 if you insist on keeping the loop.
mattip
reviewed
May 22, 2025
| @@ -819,8 +818,7 @@ def iter_subclasses(cls): | |||
| """ | |||
| for x in cls.__subclasses__(): | |||
| yield x | |||
| for y in iter_subclasses(x): | |||
| yield y | |||
| yield from iter_subclasses(x) | |||
There was a problem hiding this comment.
Is there a way to leave the explicit loop?
There was a problem hiding this comment.
I can add noqa: UP028 as well.
But what's wrong with yield from?
UP008 Use `super()` instead of `super(__class__, self)`
UP028 Replace `yield` over `for` loop with `yield from`
UP030 Use implicit references for positional format fields
UP031 Use format specifiers instead of percent format
UP031 Use format specifiers instead of percent format
UP032 Use f-string instead of `format` call
UP032 Use f-string instead of `format` call
UP036 Version block is outdated for minimum Python version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI failure seems unrelated:
Maybe related to:
asv/.github/workflows/ci_win.yml
Line 36 in d5f068b
asv/.github/workflows/triggered.yml
Line 60 in d5f068b
PyPy runs might need a higher timeout than
300.