Skip to content

MAINT: Enforce ruff/flake8-bugbear rules (B) #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

Copy link
Contributor

@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit. It is fine to do it in another PR

B006 Do not use mutable data structures for argument defaults
B007 Loop control variable not used within loop body
B009 Do not call `getattr` with a constant attribute value.
     It is not any safer than normal property access.
B010 Do not call `setattr` with a constant attribute value.
     It is not any safer than normal property access.
@DimitriPapadopoulos
Copy link
Contributor Author

Cannot make sense of the CI error yet:

FAILED test/test_continuous.py::test_continuous - KeyError: 'environments'

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the B branch 4 times, most recently from 2b10d39 to 69fd144 Compare May 22, 2025 14:07
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft May 22, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants