Draft
Conversation
5b633e2 to
51d9edb
Compare
|
This seems like a fine implementation. Clients (such as the extensions) could support whatever SVG things they want to submit to the server. Circles, rectangles, gradients etc. all fair game. Of course the official extension would likely only support basic shapes for submitting, but this looks very nice and future-proof to me. |
|
Why did you close the server side ticket? Server change is definitely required to accommodate this remedy type. |
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #538
Stored as SVGs with animations
While editing, stored as simpler types that are then converted to one svg per segment.
To play at different speeds, the svg must be modified to have all times multipled by the playback speed.
SVG tags must be generated manually since svgjs doesn't support them. They can play fine though when imported.
https://stackoverflow.com/a/51615827/1985387