-
Notifications
You must be signed in to change notification settings - Fork 6
Codex32 (BIP93) BIP85 Application reference implementation #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
BenWestgate
wants to merge
35
commits into
akarve:main
Choose a base branch
from
BenWestgate:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
4271f95
Add codex32 application to bip85.py
BenWestgate 37e4c9c
fix imports, ValueError, don't assign unused data, remove junk code b…
BenWestgate 0c1bcc7
BIP93: fix t-n = 1 bug, fixup imports, sanity checks
BenWestgate a505d0d
Create bip93.py
BenWestgate fbdb997
bip85 vectors: add BIP93 test vectors
BenWestgate 275bf26
WIP: placeholder for the full BIP93 test vectors
BenWestgate e9d4c11
test_BIP85: add test_codex32 to validate vectors
BenWestgate 535d47b
WIP: Create test_bip93.py need to find test vector
BenWestgate 3abca70
Add INDEX_TO_HRP dict
BenWestgate 276f0e5
Remove electrum, add entropy_to_codex32
BenWestgate 66ca66d
Create settings.json
BenWestgate bfa13bd
Add cli tool "codex32" for generating codex32
BenWestgate b1873d5
Update bip93_vectors.py
BenWestgate 193aae3
fix import typo
BenWestgate 33777e0
Update test_bip93.py
BenWestgate d93858d
fix codex32 help string as it uses token_bytes
BenWestgate 965f020
Add codex32 & recover features & bip85 codex32 app
BenWestgate 9a4ae77
Add codex32 dependency for bip93 encoding.
BenWestgate 65bd0b1
bip85: Import things from codex32 we'll need
BenWestgate 94b15df
add: xprv --codex32 option and `recover` command
BenWestgate 2c63697
Update README.md
BenWestgate 3b34cc7
Update README.md
BenWestgate 86308ba
Update pyproject.toml
BenWestgate 676b864
Merge pull request #3 from BenWestgate/patch-2
BenWestgate 5b2f1e3
Delete test_bip93.py
BenWestgate f24e6ac
Delete bip93_vectors.py
BenWestgate 9c26d8b
import codex32, delete non-bip85 codex32 commands
BenWestgate 143e81e
Update pyproject.toml to import codex32
BenWestgate df2a599
doc: add example of the proposed bip85 codex32 app
BenWestgate be05e2e
Delete bip93.py
BenWestgate ddb119e
Merge branch 'patch-1' of https://github.com/BenWestgate/bipsea into …
BenWestgate 14fd2d8
Delete settings.json
BenWestgate 38814cb
Update .gitignore
BenWestgate 0a9708c
Update bipsea.py
BenWestgate a1b860b
new bip85 bip93 derive proposal
BenWestgate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,4 @@ __pycache__ | |
| build | ||
| dist | ||
| .coverage | ||
| .vscode | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this new proposed path and codex32 derivation address both yours and scgbckbone feedback:
Fewer derivation levels: {header}, {n_bytes}, {index}
Fewer parameters: {share_idx} and {num_shares} are dropped
Indices output are deterministic based on k. No derived shares, just the initial k
{header} is the first 8 characters of a codex32 string, it would be some serialization of {hrp}|{threshold}{identifier} and fits if converted from bech32 to an int.
I also want to feed the bip85 app {index} into the
identas it should be unique for different seeds