Remove slow fd-closing loop that iterated up to _SC_OPEN_MAX #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove slow fd-closing loop that iterated up to _SC_OPEN_MAX - Fix incorrect O_CLOEXEC usage on pipes (use FD_CLOEXEC via fcntl) - Fix null_fd leak when redirecting stderr to /dev/null - Add portable SOCK_CLOEXEC support with fallback for macOS
The BEAM needs time to detect when a process dies and send the exit_status message. Without a grace period, the exit sequence would immediately check if the process exited after sending SIGKILL, often before the BEAM had received the notification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Related to #54