Skip to content

Conversation

@oiclid
Copy link

@oiclid oiclid commented Sep 3, 2024

… for consistency

@oiclid
Copy link
Author

oiclid commented Sep 3, 2024

This was probably blocked because I forced the branch to recognize case-sensitivity.

@Dimokus88
Copy link
Contributor

Hey @oiclid !
Thanks for this PR!
A lot of work has been done!

The PR consists mainly of changing the names of the folders that store deployment templates, where uppercase characters have been changed to lowercase.
A few changes to the versions of deployment images that are correct.

However, this PR cannot be applied in its current form, since the root README.md has not been fixed, or rather, the links to templates in it, where the links are specified in string format, have not been updated. Also, README.md > readme.md was renamed, which can cause problems when displayed in console.akash.network. For these reasons, unfortunately, we cannot accept this PR.

I would also like to draw attention to the amount of work, it is clear that you tried and we are grateful to you for this. But, as practice shows, it is easier to work with small PRs in stages and avoid numerous mistakes.

I recommend closing this PR and opening a new one by entering a step-by-step renaming of folders inside the awesome-akash repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants