[e2e] Update to quickstart fixure, add makefile, and add tests Mct7343 and 7198 #414
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /***************************************************************************** | ||
| * Open MCT, Copyright (c) 2014-2024, United States Government | ||
| * as represented by the Administrator of the National Aeronautics and Space | ||
| * Administration. All rights reserved. | ||
| * | ||
| * Open MCT is licensed under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0. | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| * Open MCT includes source code licensed under additional open source | ||
| * licenses. See the Open Source Licenses file (LICENSES.md) included with | ||
| * this source code distribution or the Licensing information page available | ||
| * at runtime from the About dialog for additional information. | ||
| *****************************************************************************/ | ||
|
|
||
| /* | ||
| This test suite is dedicated to testing our use of our custom fixtures to verify | ||
| that they are working as expected. | ||
| */ | ||
|
|
||
| import { expect, request, test} from '../quickstartFixtures.js'; | ||
|
|
||
| test.describe('quickstartFixtures tests', () => { | ||
| test('filterNonFetchRequests', async ({ page }) => { | ||
| // Listening for all network requests and pushing them into allNetworkRequests array. | ||
| page.on('request', request => allNetworkRequests.push(request)); | ||
|
|
||
| // Testing the initial page load and verifying the presence of specific elements. | ||
| await page.goto("./", { waitUntil: "networkidle" }); | ||
| fetchRequests = filterNonFetchRequests(allNetworkRequests); | ||
| expect(fetchRequests.length).toBe(4); | ||
|
|
||
| // Removing the 'request' event listener to prevent potential memory leaks. | ||
| page.removeListener('request', request => allNetworkRequests.push(request)); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* eslint-disable no-undef */ | ||
| /***************************************************************************** | ||
| * Open MCT, Copyright (c) 2014-2024, United States Government | ||
| * as represented by the Administrator of the National Aeronautics and Space | ||
| * Administration. All rights reserved. | ||
| * | ||
| * Open MCT is licensed under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0. | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| * Open MCT includes source code licensed under additional open source | ||
| * licenses. See the Open Source Licenses file (LICENSES.md) included with | ||
| * this source code distribution or the Licensing information page available | ||
| * at runtime from the About dialog for additional information. | ||
| *****************************************************************************/ | ||
|
|
||
| /** | ||
| * The file contains custom fixtures which extend the base functionality of the Playwright fixtures | ||
| * and appActions. These fixtures should be generalized across all plugins. | ||
|
There was a problem hiding this comment. this will become the prototypical fixtures file that we expect openmct-e2e-as-a-dependency users to follow. They will source |
||
| */ | ||
|
|
||
| // import { createDomainObjectWithDefaults } from './appActions.js'; | ||
| import { test, request, expect } from './opensource/pluginFixtures.js'; | ||
|
|
||
| /** | ||
| * The name of the "My Items" folder in the domain object tree. | ||
| * | ||
| * Default: `"My Items"` | ||
| * | ||
| * @type {string} | ||
| */ | ||
| export const myItemsFolderName = 'My Items'; | ||
|
|
||
| export { expect, request, test }; | ||
|
|
||
| /** | ||
| * Filters out non-fetch requests from the given array of network requests. | ||
| * This includes preflight CORS, fetching stylesheets, page icons, etc. | ||
| * Requires that a page requests object be instantiated. | ||
| * page.on('request', request => allNetworkRequests.push(request)); | ||
|
There was a problem hiding this comment. need better jsdoc |
||
| * @param {Array} requests - Array of network requests to filter. | ||
| * @returns {Array} Filtered network requests. | ||
| */ | ||
| export function filterNonFetchRequests(requests) { | ||
| return requests.filter(request => request.resourceType() === 'fetch'); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| /***************************************************************************** | ||
| * Open MCT, Copyright (c) 2014-2022, United States Government | ||
| * as represented by the Administrator of the National Aeronautics and Space | ||
| * Administration. All rights reserved. | ||
| * | ||
| * Open MCT is licensed under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0. | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| * Open MCT includes source code licensed under additional open source | ||
| * licenses. See the Open Source Licenses file (LICENSES.md) included with | ||
| * this source code distribution or the Licensing information page available | ||
| * at runtime from the About dialog for additional information. | ||
| *****************************************************************************/ | ||
| /* | ||
| * Network Specific Tests for Open MCT and YAMCS connectivity. | ||
| * This suite verifies the network requests made by the application to ensure correct interaction with YAMCS. | ||
| */ | ||
|
|
||
| import { test, expect, filterNonFetchRequests } from '../quickstartFixtures.js'; | ||
| import { createDomainObjectWithDefaults, expandEntireTree, setFixedTimeMode } from '../opensource/appActions.js'; | ||
|
|
||
| test.describe('Reload action', () => { | ||
| test.beforeEach(async ({ page }) => { | ||
| await page.goto('./', { waitUntil: 'domcontentloaded' }); | ||
|
|
||
| const displayLayout = await createDomainObjectWithDefaults(page, { | ||
| type: 'Display Layout' | ||
| }); | ||
|
|
||
| const alphaTable = await createDomainObjectWithDefaults(page, { | ||
| type: 'Telemetry Table', | ||
| name: 'Alpha Table' | ||
| }); | ||
|
|
||
| await page.getByLabel('Expand myproject folder').click(); | ||
| await page.getByLabel('Expand myproject folder').click(); | ||
| await page.locator('.c-table__body-w').click(); | ||
| await page.getByLabel('Edit Object').click(); | ||
| await page.getByRole('treeitem', { name: 'Battery1_Temp' }).dragTo(page.locator('.c-table__body-w')); | ||
|
|
||
| // Save (exit edit mode) | ||
| await page.getByRole('button', { name: 'Save' }).click(); | ||
| await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click(); | ||
|
|
||
| const betaTable = await createDomainObjectWithDefaults(page, { | ||
| type: 'Telemetry Table', | ||
| name: 'Beta Table' | ||
| }); | ||
|
|
||
| await page.locator('.c-table__body-w').click(); | ||
| await page.getByLabel('Edit Object').click(); | ||
| await page.getByRole('treeitem', { name: 'Battery1_Voltage' }).dragTo(page.locator('.c-table__body-w')); | ||
|
|
||
| // Save (exit edit mode) | ||
| await page.getByRole('button', { name: 'Save' }).click(); | ||
| await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click(); | ||
|
|
||
| await page.goto(displayLayout.url); | ||
|
|
||
|
|
||
|
|
||
| await page.getByLabel('Edit Object', { exact: true }).click(); | ||
|
|
||
| await page.dragAndDrop(`text='Alpha Table'`, '.l-layout__grid-holder', { | ||
| targetPosition: { x: 0, y: 0 } | ||
| }); | ||
|
|
||
| await page.dragAndDrop(`text='Beta Table'`, '.l-layout__grid-holder', { | ||
| targetPosition: { x: 0, y: 250 } | ||
| }); | ||
|
|
||
| await page.locator('button[title="Save"]').click(); | ||
| await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click(); | ||
| }); | ||
|
|
||
| test.only('can reload display layout and its children', async ({ page }) => { | ||
| const beforeReloadAlphaTelemetryValue = await page | ||
| .getByLabel('Alpha Table table content') | ||
| .getByLabel('wavelengths table cell') | ||
| .first() | ||
| .getAttribute('title'); | ||
| const beforeReloadBetaTelemetryValue = await page | ||
| .getByLabel('Beta Table table content') | ||
| .getByLabel('wavelengths table cell') | ||
| .first() | ||
| .getAttribute('title'); | ||
| // reload alpha | ||
| await page.getByTitle('View menu items').first().click(); | ||
| await page.getByRole('menuitem', { name: /Reload/ }).click(); | ||
|
|
||
| const afterReloadAlphaTelemetryValue = await page | ||
| .getByLabel('Alpha Table table content') | ||
| .getByLabel('wavelengths table cell') | ||
| .first() | ||
| .getAttribute('title'); | ||
| const afterReloadBetaTelemetryValue = await page | ||
| .getByLabel('Beta Table table content') | ||
| .getByLabel('wavelengths table cell') | ||
| .first() | ||
| .getAttribute('title'); | ||
|
|
||
| expect(beforeReloadAlphaTelemetryValue).not.toEqual(afterReloadAlphaTelemetryValue); | ||
| expect(beforeReloadBetaTelemetryValue).toEqual(afterReloadBetaTelemetryValue); | ||
|
|
||
| // now reload parent | ||
| await page.getByTitle('More actions').click(); | ||
| await page.getByRole('menuitem', { name: /Reload/ }).click(); | ||
|
|
||
| const fullReloadAlphaTelemetryValue = await page | ||
| .getByLabel('Alpha Table table content') | ||
| .getByLabel('wavelengths table cell') | ||
| .first() | ||
| .getAttribute('title'); | ||
| const fullReloadBetaTelemetryValue = await page | ||
| .getByLabel('Beta Table table content') | ||
| .getByLabel('wavelengths table cell') | ||
| .first() | ||
| .getAttribute('title'); | ||
|
|
||
| expect(fullReloadAlphaTelemetryValue).not.toEqual(afterReloadAlphaTelemetryValue); | ||
|
There was a problem hiding this comment. These earlier tests were predicated on the sinewave generator, that created new telemetry on every page load. If we're going to use YAMCS telemetry, we can't rely on the telemetry changing underneath us on reload. There was a problem hiding this comment. Long and short of it: I think we should get rid of these expects There was a problem hiding this comment. And instead add some network measuring on reload. I think this will be the best to see if the reload actually performed as expected There was a problem hiding this comment. This still makes sense 9 months later to me 😀 |
||
| expect(fullReloadBetaTelemetryValue).not.toEqual(afterReloadBetaTelemetryValue); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
driveby. We're moving away from 'false' for faster debugging