refac: reorganize wallet connection architecture#182
Merged
akiraonstarknet merged 1 commit intoakiraonstarknet:devfrom Oct 10, 2025
Merged
refac: reorganize wallet connection architecture#182akiraonstarknet merged 1 commit intoakiraonstarknet:devfrom
akiraonstarknet merged 1 commit intoakiraonstarknet:devfrom
Conversation
|
@EjembiEmmanuel is attempting to deploy a commit to the zkdice-xyz's projects Team on Vercel. A member of the Team first needs to authorize it. |
- Extract Providers to separate component - Create dedicated ConnectButton component - Add connectors module - Remove legacy wallet hooks
4c6be7c to
50b9ab3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Fixes:
What Changed
This PR reorganizes the wallet connection architecture by:
ConnectButtoncomponent: Extracted wallet connection UI logic into a dedicated, reusable componentProvidersto components: Relocated fromsrc/app/template.tsxtosrc/components/Providers.tsxfor better organizationconnectorsmodule: Centralized Starknet wallet connector configuration (ArgentMobile, Braavos, ArgentX, etc.)useWalletConnection.tsxandwallet.tsin favor of the new architectureNavbar.tsx,Strategy.tsx,YieldCard.tsx, andlayout.tsxto use the new componentsBenefits
Vercel website link
Checklist before requesting a review