feat: Transform event and metadata of replicated event#32650
Merged
Conversation
patriknw
commented
Feb 10, 2025
| */ | ||
| @ApiMayChange | ||
| @InternalStableApi | ||
| def withReplicatedEventTransformation( |
Contributor
Author
There was a problem hiding this comment.
I think we can have this as internal api, since it's needed for a rather special thing in Akka runtime.
| val metadataEntriesFromReplicatedEvent = | ||
| event.metadata match { | ||
| case None => Nil | ||
| case Some(_: ReplicatedEventMetadata) => Nil |
Contributor
Author
There was a problem hiding this comment.
the new replicatedEventMetadata will anyway override any existing ReplicatedEventMetadata
johanandren
reviewed
Feb 10, 2025
| val addTransformation | ||
| : EventSourcedBehavior[Command, String, State] => EventSourcedBehavior[Command, String, State] = | ||
| _.withReplicatedEventTransformation { (_, event) => | ||
| (event.toUpperCase, None) |
Contributor
There was a problem hiding this comment.
Add some metadata test coverage as well for good measure?
johanandren
approved these changes
Feb 14, 2025
patriknw
force-pushed
the
wip-res-transform-patriknw
branch
from
4a5af69 to
e375880
Compare
Contributor
Author
|
added metadata test and found some things that were not correct: e375880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.