Conversation
|
Interesting. It seems that |
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
LGTM, but let's release 2.10.10 with some bug fixes before merging this bump
|
I would like to get rid of the added |
| object Compile { | ||
| // Compile | ||
|
|
||
| val scalaLibrary = "org.scala-lang" % "scala-library" % scala213Version |
There was a problem hiding this comment.
Wouldn't this be strange for Scala 3?
| // store hashCode | ||
| @nowarn("msg=deprecated") | ||
| @transient override lazy val hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this) | ||
| @transient override lazy val hashCode: Int = scala.util.hashing.MurmurHash3.caseClassHash(this) |
There was a problem hiding this comment.
Let's stay with the deprecated productHash. caseClassHash doesn't exist in earlier Scala library versions so if someone ends up running with earlier Scala version this will be a fatal error.
|
I'll pick this up in a new PR directly against the repo so we can verify the samples and native image are working right away. |
|
@johanandren Can you also revert the change caseClassHash/productHash |
3 participants
No description provided.