perf: use StackWalker for logger class detection#32917
Open
perf: use StackWalker for logger class detection#32917
Conversation
Contributor
retronym
commented
Apr 28, 2026
retronym
commented
- Replace legacy SecurityManager-based stack walking with Java 9+ StackWalker API
- Improve performance by lazily streaming stack frames instead of capturing full class context
- Remove TrickySecurityManager internal utility which is no longer needed
- Add JUnit test case to verify logger detection through indirect call frames
|
Hi @retronym, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Akka Contributors License Agreement before, however, the CLA has changed since you last signed it. |
retronym
force-pushed
the
stackwalker
branch
2 times, most recently
from
f7f3a06 to
12269e1
Compare
* Replace legacy SecurityManager-based stack walking with Java 9+ StackWalker API * Improve performance by lazily streaming stack frames instead of capturing full class context * Remove TrickySecurityManager internal utility which is no longer needed * Add JUnit test case to verify logger detection through indirect call frames
Contributor
Author
|
@johanandren where do I place the MiMa exclusion for the removed class? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.