Merged
Conversation
akka-ci
added
validating
|
Test PASSed. |
Contributor
|
Could you add a few tests for those newly allowed UUIDs so that we can see that |
Philippus
force-pushed
the
widen-uuid-regexp
branch
from
ea8b9bf to
223b0bc
Compare
akka-ci
added
validating
|
Test PASSed. |
jrudolph
approved these changes
Aug 1, 2019
Contributor
jrudolph
left a comment
jrudolph
left a comment
There was a problem hiding this comment.
Thanks @Philippus. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Widen JavaUUID regex's (again) to allow for old and future variants of uuid's (described in chapter 4.1.1 of RFC 4122.
References
Following-up after #2569 and #2596. Thanks to @plokhotnyuk for pointing this out in spray/spray-json#313.