Skip to content

Skip parsing PropertyNames when empty Parameters #7960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snakefoot wants to merge 4 commits into
base: dev
Choose a base branch
from
+2 −35
Open

Skip parsing PropertyNames when empty Parameters #7960

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4009145
Skip parsing PropertyNames when not Parameters
snakefoot Dec 7, 2025
5be8bd8
Merge branch 'dev' into dev
snakefoot Dec 11, 2025
d98b6a2
Merge branch 'dev' into dev
Arkatufus Dec 17, 2025
340d821
Simplify code
Arkatufus Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 2 additions & 35 deletions src/core/Akka/Event/LogMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,22 +75,16 @@ public IReadOnlyDictionary<string, object> GetProperties()
{
if (_properties == null)
{
var names = PropertyNames;
var parameters = Parameters();

// Optimize: avoid ToArray() if Parameters() already returns IReadOnlyList
if (parameters is IReadOnlyList<object> readOnlyList)
{
_properties = CreatePropertyDictionary(names, readOnlyList);
}
else if (parameters is object[] array)
{
_properties = CreatePropertyDictionary(names, array);
_properties = CreatePropertyDictionary(PropertyNames, readOnlyList);
}
else
{
// Fallback: convert to array
_properties = CreatePropertyDictionary(names, parameters.ToArray());
_properties = CreatePropertyDictionary(PropertyNames, parameters.ToArray());
}
}
return _properties;
Expand All @@ -115,33 +109,6 @@ private static IReadOnlyDictionary<string, object> CreatePropertyDictionary(
dict[names[i]] = values[i];
}

#if NET8_0_OR_GREATER
// Use FrozenDictionary for optimal read performance on .NET 8+
return System.Collections.Frozen.FrozenDictionary.ToFrozenDictionary(dict);
#else
return dict;
#endif
}

private static IReadOnlyDictionary<string, object> CreatePropertyDictionary(
IReadOnlyList<string> names,
object[] values)
{
// Handle empty case
if (names.Count == 0)
return EmptyDictionary;

// Handle mismatched counts (more values than names, or vice versa)
var count = Math.Min(names.Count, values.Length);
if (count == 0)
return EmptyDictionary;

var dict = new Dictionary<string, object>(count);
for (int i = 0; i < count; i++)
{
dict[names[i]] = values[i];
}

#if NET8_0_OR_GREATER
// Use FrozenDictionary for optimal read performance on .NET 8+
return System.Collections.Frozen.FrozenDictionary.ToFrozenDictionary(dict);
Expand Down