In RemotingTerminator, avoid racy FSM log init. #7967
+37
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemotingTerminator is initialized during Provider Start. FSM constructor initializes the _log with `context.GetLogger()` which eventually leads into `LogSource.FromActorRef()`. This method attempts to access `Provider.DefaultAddress`, which is being initialized. If Provider `Init()` loses the race, either its `RemoteInternals` is not set, causing NRE, or if `Remoting.Start()` is not completed, the `_defaultAddress` is not set and returns null. This commit removes the FSM from `RemotingTerminator` and manually implements it using `Become()` API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7966
Changes
This PR removes the use of FSM from
RemotingTerminatorand manually implements it usingBecome()API.