feat: tap recognizer with full test infrastructure - #1
Merged
Conversation
Core: PointerTracker, BaseRecognizer, Manager, Arbitrator Recognizer: TapRecognizer with convenience API, state machine, threshold/interval Testing: 144 unit tests (vitest), 54 E2E tests (Playwright x3 browsers), Stryker mutation testing at 94.35% Tooling: ESLint strict, Prettier, husky pre-commit, size-limit, GitHub Actions CI, dependabot Docs: VitePress site with Gruvbox theme, interactive demos, API reference, guides
- Manager calls setPointerCapture on pointerdown so recognizers receive move/up/cancel even when the pointer leaves the element bounds - TapRecognizer defaults moved from instance fields to module-level const - PointerTracker.onPointerDown guards against duplicate pointer IDs
- getting-started.md: RECOGNIZED → Recognized (matches enum value) - tap.md: Failed→Idle reset is deferred to pointerup/cancel, not automatic - .gitignore: add tmp/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tap()function, threshold/interval options, CustomEvent dispatchTest plan
npm test— 549 unit tests passnpm run test:e2e— Playwright tests pass on chromium/firefox/webkitnpm run build— tsup builds cleanly with declarationsnpm run lint— no ESLint errorsnpm run test:mutate— Stryker score above 85% threshold