feat: double-tap recognizer with tap/doubletap arbitration - #2
Merged
Conversation
DoubleTapRecognizer detects two consecutive taps within a configurable interval and movement threshold. TapRecognizer gains deferred recognition via requireFailureOf so single-tap waits for doubletap to fail first. 68 unit tests, 22 E2E tests across 3 browsers, Stryker 89.05%.
- Clear onResolvedCallbacks in reset() to prevent unbounded accumulation - Require same pointer ID for second tap in doubletap recognizer - Add activePointerId guard to onPointerCancel in doubletap recognizer - Reorder tracker.onPointerMove after pointerId guard in tap recognizer - Fix test description that contradicted its assertion - Fix interval docs to clarify pointerup-to-pointerup measurement - Fix misleading priority comment in doubletap docs - Remove incorrect Arbitrator step from contributing.md routing diagram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireFailureOf— tap defers until doubletap failsonResolvedcallback system for deferred recognitiondoubleTap()function with callback and options formsfngr:doubletap)Test plan
npm test— 212 unit tests passnpm run test:e2e— Playwright tests pass on chromium/firefox/webkitnpm run build— tsup builds cleanlynpm run lint— no ESLint errorsnpm run test:mutate— Stryker score above 85%